September 2009 - DVDnav-discuss - lists.mplayerhq.hu

[PATCH 0/6] catch up to 0.9.6 and a couple of extras
by Erik Hovland 10 Oct '11

10 Oct '11

In an attempt to work towards getting Jorgen's patches in, I have taken on the task of catching up the mplayer tree of libdvdread to 0.9.6. Next will be 0.9.7. But I figured that I can submit that in its own chunk. This patch set also includes some cosmetic fixes as well as a potential memory leak fix and a check of a few system calls. Enjoy E --- Erik Hovland (6): 0.9.6 included a few items to improve the sofware on the *BSD Add in DVDFileStat Add the version function DVDVersion(). The version should be bumped to at least 5. But I am going to go to 6 on this one. Make cosmetic changes to files. Some system calls that report errors are not being checked. msvc/include/pthreads/pthread.h | 6 - msvc/include/sys/time.h | 2 msvc/include/unistd.h | 4 - src/bitreader.c | 2 src/dvd_input.c | 2 src/dvd_reader.c | 258 ++++++++++++++++++++++++++++++++++++--- src/dvd_udf.c | 4 - src/dvdread/dvd_reader.h | 47 ++++++- src/dvdread/ifo_types.h | 2 src/dvdread/nav_types.h | 8 + src/ifo_print.c | 22 ++- src/md5.c | 4 - src/nav_print.c | 2 13 files changed, 302 insertions(+), 61 deletions(-) -- Signature

7 34

[PATCH] UDF2.50 part 1
by Jorgen Lundman 06 Oct '11

06 Oct '11

Separated RAR support, as it is the most questionble change in the old patch. Told emacs to never use tabs too, so it should be cleaner. Add UDF2.50 logic, which includes BD5ISO, and HD-DVD support. Support non-DVD style access. (File iteration, and reading). Diffed against svn 1153. This patch includes: 1. Add ExtFinfo (262) support 2. Add FileType (250) re-direct support 3. DVDOpendir/DVDReaddir/DVDClosedir/DVDOpenFile for UDF access. 4. dvdread-1.9.7 stat methods for obtaining VOB data and sizes 5. AD chaining, instead of assuming files will always fit in 1 AD group. 6. dvd_udf API uses "UDF_FILE" type instead of "starting block number". 7. Separate struct AD and struct FileAD instead of ugly 64->32 bit work. 8. Minor memory clearing problems, and memory leaks. Lund -- Jorgen Lundman | <lundman(a)lundman.net> Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work) Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell) Japan | +81 (0)3 -3375-1767 (home) -- Jorgen Lundman | <lundman(a)lundman.net> Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work) Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell) Japan | +81 (0)3 -3375-1767 (home) -- Jorgen Lundman | <lundman(a)lundman.net> Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work) Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell) Japan | +81 (0)3 -3375-1767 (home)

6 35

"libdvdread: Invalid main menu IFO" on ppc
by Dominik 'Rathann' Mierzejewski 05 Mar '10

05 Mar '10

I've just received a bug report: === Opened by W. Michael Petullo on 2008-04-15 04:11 EST [reply] Description of problem: I have been unable to play DVD's with gstreamer-plugins-ugly-0.10.7-1.lvn9.ppc when it is built against libdvdread-4.1.1-6.fc9.ppc. I rebuilt gstreamer-plugins-ugly against the older libdvdread-0.9.7-3.fc8 and it worked fine. I receive an error that states, "libdvdread: Invalid main menu IFO (VIDEO_TS.IFO)." Here is an example: > gst-launch dvdreadsrc device=/dev/hdc ! dvddemux name=dvd dvd. ! mpeg2dec ! queue ! ffmpegcolorspace ! xvimagesink dvd. ! a52dec ! audioconvert ! audioresample ! queue ! osssink Setting pipeline to PAUSED ... No accelerated IMDCT transform found libdvdread: Using libdvdcss version 1.2.9 for DVD access libdvdread: Invalid main menu IFO (VIDEO_TS.IFO). ERROR: Pipeline doesn't want to pause. ERROR: from element /pipeline0/dvdreadsrc0: Could not open DVD Additional debug info: dvdreadsrc.c(236): gst_dvd_read_src_start (): /pipeline0/dvdreadsrc0: ifoOpen() failed: File exists Setting pipeline to NULL ... FREEING pipeline ... [...] === https://bugzilla.redhat.com/show_bug.cgi?id=442508 Regards, R. -- Fedora contributor http://fedoraproject.org/wiki/DominikMierzejewski Livna contributor http://rpm.livna.org MPlayer developer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"

3 20

Assert in vm.c
by Jorgen Lundman 30 Sep '09

30 Sep '09

I came across an assert in Windows, in the libdvdnav/vm/vm.c; line 177; close(fd); and same call again; line 217; close(fd); which unfortunately means program gets terminated in Windows. -- Jorgen Lundman | <lundman(a)lundman.net> Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work) Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell) Japan | +81 (0)3 -3375-1767 (home)

2 3

r1180 - trunk/libdvdnav/src/vm/vm.c
by erik 26 Sep '09

26 Sep '09

Author: erik Date: Sun Sep 6 17:26:39 2009 New Revision: 1180 Log: OS/2 portability fix This commit only touches the OS/2 port. The function os2_open is changed to perform the large file open call instead of the regular file open call. And there is a setmode call to explicitly set the DOS file mode to binary. This commit is directly from the patch sent in by KO Myung-Hun <komh AT chollian DOT net>. Thanks! Modified: trunk/libdvdnav/src/vm/vm.c Modified: trunk/libdvdnav/src/vm/vm.c ============================================================================== --- trunk/libdvdnav/src/vm/vm.c Wed Sep 2 03:44:16 2009 (r1179) +++ trunk/libdvdnav/src/vm/vm.c Sun Sep 6 17:26:39 2009 (r1180) @@ -54,6 +54,8 @@ #ifdef __OS2__ #define INCL_DOS #include <os2.h> +#include <io.h> /* setmode() */ +#include <fcntl.h> /* O_BINARY */ #endif /* @@ -144,14 +146,16 @@ static int os2_open(const char *name, in ULONG ulAction; ULONG rc; - rc = DosOpen( name, &hfile, &ulAction, 0, FILE_NORMAL, - OPEN_ACTION_OPEN_IF_EXISTS | OPEN_ACTION_FAIL_IF_NEW, - OPEN_ACCESS_READONLY | OPEN_SHARE_DENYNONE | OPEN_FLAGS_DASD, - NULL ); + rc = DosOpenL( name, &hfile, &ulAction, 0, FILE_NORMAL, + OPEN_ACTION_OPEN_IF_EXISTS | OPEN_ACTION_FAIL_IF_NEW, + OPEN_ACCESS_READONLY | OPEN_SHARE_DENYNONE | OPEN_FLAGS_DASD, + NULL ); if( rc ) return -1; + setmode( hfile, O_BINARY ); + return ( int )hfile; } #endif

3 3

r1184 - in trunk/libdvdnav: configure.ac configure2
by rathann 26 Sep '09

26 Sep '09

Author: rathann Date: Sun Sep 27 00:44:38 2009 New Revision: 1184 Log: bump version due to dvdnav_get_serial_string addition Modified: trunk/libdvdnav/configure.ac trunk/libdvdnav/configure2 Modified: trunk/libdvdnav/configure.ac ============================================================================== --- trunk/libdvdnav/configure.ac Sun Sep 27 00:23:58 2009 (r1183) +++ trunk/libdvdnav/configure.ac Sun Sep 27 00:44:38 2009 (r1184) @@ -14,7 +14,7 @@ dnl These are defined in m4 so they can dnl -------------------------------------------------------------- m4_define([dvdnav_major], [4]) m4_define([dvdnav_minor], [1]) -m4_define([dvdnav_sub], [3]) +m4_define([dvdnav_sub], [4]) m4_define([dvdnav_pre], []) AC_INIT([libdvdnav], [dvdnav_major.dvdnav_minor.dvdnav_sub[]dvdnav_pre]) Modified: trunk/libdvdnav/configure2 ============================================================================== --- trunk/libdvdnav/configure2 Sun Sep 27 00:23:58 2009 (r1183) +++ trunk/libdvdnav/configure2 Sun Sep 27 00:44:38 2009 (r1184) @@ -1,6 +1,6 @@ #!/bin/sh -dvdnav_sh_version=4.1.3 +dvdnav_sh_version=4.1.4 dvdnav_sh_major=`echo $dvdnav_sh_version | awk -F. '{print $1}'` cc=gcc

1 0

r1183 - in trunk/libdvdread: configure.ac configure2
by rathann 26 Sep '09

26 Sep '09

Author: rathann Date: Sun Sep 27 00:23:58 2009 New Revision: 1183 Log: bump version due to DVDFileStat addition Modified: trunk/libdvdread/configure.ac trunk/libdvdread/configure2 Modified: trunk/libdvdread/configure.ac ============================================================================== --- trunk/libdvdread/configure.ac Sun Sep 27 00:23:26 2009 (r1182) +++ trunk/libdvdread/configure.ac Sun Sep 27 00:23:58 2009 (r1183) @@ -14,7 +14,7 @@ dnl These are defined in m4 so they can dnl -------------------------------------------------------------- m4_define([dvdread_major], [4]) m4_define([dvdread_minor], [1]) -m4_define([dvdread_sub], [3]) +m4_define([dvdread_sub], [4]) m4_define([dvdread_pre], []) AC_INIT([libdvdread], [dvdread_major.dvdread_minor.dvdread_sub[]dvdread_pre]) Modified: trunk/libdvdread/configure2 ============================================================================== --- trunk/libdvdread/configure2 Sun Sep 27 00:23:26 2009 (r1182) +++ trunk/libdvdread/configure2 Sun Sep 27 00:23:58 2009 (r1183) @@ -1,6 +1,6 @@ #!/bin/sh -dvdread_sh_version=4.1.3 +dvdread_sh_version=4.1.4 dvdread_sh_major=`echo $dvdread_sh_version | awk -F. '{print $1}'` cc=gcc

1 0

r1182 - trunk/libdvdread/configure2
by rathann 26 Sep '09

26 Sep '09

Author: rathann Date: Sun Sep 27 00:23:26 2009 New Revision: 1182 Log: cosmetics: remove trailing whitespace Modified: trunk/libdvdread/configure2 Modified: trunk/libdvdread/configure2 ============================================================================== --- trunk/libdvdread/configure2 Sun Sep 6 17:26:43 2009 (r1181) +++ trunk/libdvdread/configure2 Sun Sep 27 00:23:26 2009 (r1182) @@ -108,7 +108,7 @@ case $targetos in ;; esac -cat > config.mak << EOF +cat > config.mak << EOF # Automatically generated by configure, do not edit PREFIX=$PREFIX libdir=$libdir

1 0

Feature Request: return meaningful error message when region is unset on a RPC-II drive
by Dominik 'Rathann' Mierzejewski 26 Sep '09

26 Sep '09

Hi all! There's a feature request on Fedora bug tracker, asking for a meaningful error message when failing to read DVD on a RPC-II drive with unset region. https://bugzilla.redhat.com/show_bug.cgi?id=499796 Maybe we could use FFmpeg's or MPlayer's bugtracker for dvdnav, too? Regards, R. -- Fedora http://fedoraproject.org/wiki/User:Rathann RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"

1 0

Re: [DVDnav-discuss] undvd utility
by Nico Sabbi 18 Sep '09

18 Sep '09

Il venerdì 18 settembre 2009 10:58:22 hai scritto: > Seriously, it is no more than 5 minutes of code. But with the 2 > weeks getting the patch approved due to "too many spaces", it just > isn't appealing to me. I would love to be able to run the > "official" libdvdnav, but it is just too far behind. in the case of an external tool like this there's no problem, but it will undergo a trailing whitespace removal to pass svn precommit hooks.

2 1