August 2009 - DVDnav-discuss - lists.mplayerhq.hu

[PATCH 0/6] catch up to 0.9.6 and a couple of extras
by Erik Hovland 10 Oct '11

10 Oct '11

In an attempt to work towards getting Jorgen's patches in, I have taken on the task of catching up the mplayer tree of libdvdread to 0.9.6. Next will be 0.9.7. But I figured that I can submit that in its own chunk. This patch set also includes some cosmetic fixes as well as a potential memory leak fix and a check of a few system calls. Enjoy E --- Erik Hovland (6): 0.9.6 included a few items to improve the sofware on the *BSD Add in DVDFileStat Add the version function DVDVersion(). The version should be bumped to at least 5. But I am going to go to 6 on this one. Make cosmetic changes to files. Some system calls that report errors are not being checked. msvc/include/pthreads/pthread.h | 6 - msvc/include/sys/time.h | 2 msvc/include/unistd.h | 4 - src/bitreader.c | 2 src/dvd_input.c | 2 src/dvd_reader.c | 258 ++++++++++++++++++++++++++++++++++++--- src/dvd_udf.c | 4 - src/dvdread/dvd_reader.h | 47 ++++++- src/dvdread/ifo_types.h | 2 src/dvdread/nav_types.h | 8 + src/ifo_print.c | 22 ++- src/md5.c | 4 - src/nav_print.c | 2 13 files changed, 302 insertions(+), 61 deletions(-) -- Signature

7 34

[PATCH] UDF2.50 part 1
by Jorgen Lundman 06 Oct '11

06 Oct '11

Separated RAR support, as it is the most questionble change in the old patch. Told emacs to never use tabs too, so it should be cleaner. Add UDF2.50 logic, which includes BD5ISO, and HD-DVD support. Support non-DVD style access. (File iteration, and reading). Diffed against svn 1153. This patch includes: 1. Add ExtFinfo (262) support 2. Add FileType (250) re-direct support 3. DVDOpendir/DVDReaddir/DVDClosedir/DVDOpenFile for UDF access. 4. dvdread-1.9.7 stat methods for obtaining VOB data and sizes 5. AD chaining, instead of assuming files will always fit in 1 AD group. 6. dvd_udf API uses "UDF_FILE" type instead of "starting block number". 7. Separate struct AD and struct FileAD instead of ugly 64->32 bit work. 8. Minor memory clearing problems, and memory leaks. Lund -- Jorgen Lundman | <lundman(a)lundman.net> Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work) Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell) Japan | +81 (0)3 -3375-1767 (home) -- Jorgen Lundman | <lundman(a)lundman.net> Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work) Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell) Japan | +81 (0)3 -3375-1767 (home) -- Jorgen Lundman | <lundman(a)lundman.net> Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work) Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell) Japan | +81 (0)3 -3375-1767 (home)

6 35

"libdvdread: Invalid main menu IFO" on ppc
by Dominik 'Rathann' Mierzejewski 05 Mar '10

05 Mar '10

I've just received a bug report: === Opened by W. Michael Petullo on 2008-04-15 04:11 EST [reply] Description of problem: I have been unable to play DVD's with gstreamer-plugins-ugly-0.10.7-1.lvn9.ppc when it is built against libdvdread-4.1.1-6.fc9.ppc. I rebuilt gstreamer-plugins-ugly against the older libdvdread-0.9.7-3.fc8 and it worked fine. I receive an error that states, "libdvdread: Invalid main menu IFO (VIDEO_TS.IFO)." Here is an example: > gst-launch dvdreadsrc device=/dev/hdc ! dvddemux name=dvd dvd. ! mpeg2dec ! queue ! ffmpegcolorspace ! xvimagesink dvd. ! a52dec ! audioconvert ! audioresample ! queue ! osssink Setting pipeline to PAUSED ... No accelerated IMDCT transform found libdvdread: Using libdvdcss version 1.2.9 for DVD access libdvdread: Invalid main menu IFO (VIDEO_TS.IFO). ERROR: Pipeline doesn't want to pause. ERROR: from element /pipeline0/dvdreadsrc0: Could not open DVD Additional debug info: dvdreadsrc.c(236): gst_dvd_read_src_start (): /pipeline0/dvdreadsrc0: ifoOpen() failed: File exists Setting pipeline to NULL ... FREEING pipeline ... [...] === https://bugzilla.redhat.com/show_bug.cgi?id=442508 Regards, R. -- Fedora contributor http://fedoraproject.org/wiki/DominikMierzejewski Livna contributor http://rpm.livna.org MPlayer developer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"

3 20

please review: DVDFileStat, close dev on error, use parens and BSD porting bits
by Erik Hovland 01 Sep '09

01 Sep '09

I finally got my act together on the whoe dvdnav/dvdread svn write access. So I am asking for a last review before I commit these patches to the repo. 0001 The already sent (and already approved) DVDFileStat addition to the API 0002 Close a dvd file struct in an error path (another finger in the proverbial dike) 0003 Use parens to make mask off of 'is present' bit explicit 0004 Add the *BSD bits from libdvdread 0.9.7 Thanks E -- Erik Hovland erik(a)hovland.org http://hovland.org/

3 7

Re: [DVDnav-discuss] please review: DVDFileStat, close dev on error, use parens and BSD porting bits
by Erik Hovland 31 Aug '09

31 Aug '09

----- Original message ----- > On Sun, Aug 30, 2009 at 05:24:56PM -0700, Erik Hovland wrote: > > I finally got my act together on the whoe dvdnav/dvdread svn write > > access. So I am > > asking for a last review before I commit these patches to the repo. > > Get rid of the trailing whitespace. Will do. > > > --- a/src/dvd_reader.c > > +++ b/src/dvd_reader.c > > @@ -897,6 +903,187 @@ void DVDCloseFile( dvd_file_t *dvd_file ) > > > > + if( title == 0 ) { > > + if(!UDFFindFile( dvd, filename, &size )) { > > + if( !menu ) { > > + for( cur = 2; cur < 10; cur++ ) { > > + if( !UDFFindFile( dvd, filename, &size ) ) { > > + for(n = 0; n < nr_parts; n++) { > > + if( title == 0 ) { > > + if( !findDVDFile( dvd, filename, full_path ) ) { > > + if( stat( full_path, &fileinfo ) < 0 ) { > > Even within a single function you inconsistently format your statements. > I suggest dropping the spaces within the parentheses. In my defense, that inconsistency is pulled straight from the 0.9.7 tree. I have no problem being more rigid about the style. But it will make it harder for others to diff the same trees and come up w/ the same comparisons. I would prefer to fix the code style in a 2nd patch. E

1 0

[PATCH] Packaging failure
by John Stebbins 29 Aug '09

29 Aug '09

Some package tools run configure as fakeroot. This triggers code in configure.ac that detects uid 0 to hardcode the installation path of the m4 macros to the system aclocal macro dir. This ignores any DESTDIR the packaging tools may have set and installation fails since it attempts to write to a system dir without proper permissions. These patches maintain the current behaviour if uid==0 && DESTDIR is empty. Otherwise, DESTDIR and the regular datadir path are used.

2 3

r1175 - in trunk/libdvdread/src: dvd_reader.c dvdread_internal.h
by nicodvb 04 Aug '09

04 Aug '09

Author: nicodvb Date: Tue Aug 4 23:21:49 2009 New Revision: 1175 Log: replaced conditional checks on MSC with _WIN32 to permit MINGW to mount and decrypt images; patch by John Stebbins (stebbing jetheaddev com) Modified: trunk/libdvdread/src/dvd_reader.c trunk/libdvdread/src/dvdread_internal.h Modified: trunk/libdvdread/src/dvd_reader.c ============================================================================== --- trunk/libdvdread/src/dvd_reader.c Tue Jun 9 00:02:37 2009 (r1174) +++ trunk/libdvdread/src/dvd_reader.c Tue Aug 4 23:21:49 2009 (r1175) @@ -333,7 +333,7 @@ dvd_reader_t *DVDOpen( const char *ppath char *dev_name = NULL; char *path = NULL, *new_path = NULL, *path_copy = NULL; -#ifdef _MSC_VER +#ifdef _WIN32 int len; #endif @@ -347,7 +347,7 @@ dvd_reader_t *DVDOpen( const char *ppath /* Try to open libdvdcss or fall back to standard functions */ have_css = dvdinput_setup(); -#ifdef _MSC_VER +#ifdef _WIN32 /* Strip off the trailing \ if it is not a drive */ len = strlen(path); if ((len > 1) && @@ -506,11 +506,11 @@ dvd_reader_t *DVDOpen( const char *ppath } fclose( mntfile ); } -#elif defined(_MSC_VER) || defined(__OS2__) +#elif defined(_WIN32) || defined(__OS2__) auth_drive = DVDOpenImageFile( path, have_css ); #endif -#if !defined(_MSC_VER) && !defined(__OS2__) +#if !defined(_WIN32) && !defined(__OS2__) if( !dev_name ) { fprintf( stderr, "libdvdread: Couldn't find device name.\n" ); } else if( !auth_drive ) { Modified: trunk/libdvdread/src/dvdread_internal.h ============================================================================== --- trunk/libdvdread/src/dvdread_internal.h Tue Jun 9 00:02:37 2009 (r1174) +++ trunk/libdvdread/src/dvdread_internal.h Tue Aug 4 23:21:49 2009 (r1175) @@ -19,9 +19,9 @@ #ifndef LIBDVDREAD_DVDREAD_INTERNAL_H #define LIBDVDREAD_DVDREAD_INTERNAL_H -#ifdef _MSC_VER +#ifdef _WIN32 #include <unistd.h> -#endif /* _MSC_VER */ +#endif /* _WIN32 */ #define CHECK_VALUE(arg) \ if(!(arg)) { \

1 0

Use of _MSC_VER defines doesn't work for mingw compile
by John Stebbins 01 Aug '09

01 Aug '09

dvd_reader.c and dvdread_internal.h use a mix of _WIN32 and _MSC_VER for windows specific code. _WIN32 works for mingw, but _MSC_VER does not. The practical effect of the incorrectly built code is that the dvd is not opened as an image and thus the css keys are never obtained and decryption doesn't happen. Patch attached.

3 5