February 2009 - DVDnav-discuss - lists.mplayerhq.hu

[PATCH 0/6] catch up to 0.9.6 and a couple of extras
by Erik Hovland 10 Oct '11

10 Oct '11

In an attempt to work towards getting Jorgen's patches in, I have taken on the task of catching up the mplayer tree of libdvdread to 0.9.6. Next will be 0.9.7. But I figured that I can submit that in its own chunk. This patch set also includes some cosmetic fixes as well as a potential memory leak fix and a check of a few system calls. Enjoy E --- Erik Hovland (6): 0.9.6 included a few items to improve the sofware on the *BSD Add in DVDFileStat Add the version function DVDVersion(). The version should be bumped to at least 5. But I am going to go to 6 on this one. Make cosmetic changes to files. Some system calls that report errors are not being checked. msvc/include/pthreads/pthread.h | 6 - msvc/include/sys/time.h | 2 msvc/include/unistd.h | 4 - src/bitreader.c | 2 src/dvd_input.c | 2 src/dvd_reader.c | 258 ++++++++++++++++++++++++++++++++++++--- src/dvd_udf.c | 4 - src/dvdread/dvd_reader.h | 47 ++++++- src/dvdread/ifo_types.h | 2 src/dvdread/nav_types.h | 8 + src/ifo_print.c | 22 ++- src/md5.c | 4 - src/nav_print.c | 2 13 files changed, 302 insertions(+), 61 deletions(-) -- Signature

7 34

[PATCH] UDF2.50 part 1
by Jorgen Lundman 06 Oct '11

06 Oct '11

Separated RAR support, as it is the most questionble change in the old patch. Told emacs to never use tabs too, so it should be cleaner. Add UDF2.50 logic, which includes BD5ISO, and HD-DVD support. Support non-DVD style access. (File iteration, and reading). Diffed against svn 1153. This patch includes: 1. Add ExtFinfo (262) support 2. Add FileType (250) re-direct support 3. DVDOpendir/DVDReaddir/DVDClosedir/DVDOpenFile for UDF access. 4. dvdread-1.9.7 stat methods for obtaining VOB data and sizes 5. AD chaining, instead of assuming files will always fit in 1 AD group. 6. dvd_udf API uses "UDF_FILE" type instead of "starting block number". 7. Separate struct AD and struct FileAD instead of ugly 64->32 bit work. 8. Minor memory clearing problems, and memory leaks. Lund -- Jorgen Lundman | <lundman(a)lundman.net> Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work) Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell) Japan | +81 (0)3 -3375-1767 (home) -- Jorgen Lundman | <lundman(a)lundman.net> Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work) Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell) Japan | +81 (0)3 -3375-1767 (home) -- Jorgen Lundman | <lundman(a)lundman.net> Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work) Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell) Japan | +81 (0)3 -3375-1767 (home)

6 35

"libdvdread: Invalid main menu IFO" on ppc
by Dominik 'Rathann' Mierzejewski 05 Mar '10

05 Mar '10

I've just received a bug report: === Opened by W. Michael Petullo on 2008-04-15 04:11 EST [reply] Description of problem: I have been unable to play DVD's with gstreamer-plugins-ugly-0.10.7-1.lvn9.ppc when it is built against libdvdread-4.1.1-6.fc9.ppc. I rebuilt gstreamer-plugins-ugly against the older libdvdread-0.9.7-3.fc8 and it worked fine. I receive an error that states, "libdvdread: Invalid main menu IFO (VIDEO_TS.IFO)." Here is an example: > gst-launch dvdreadsrc device=/dev/hdc ! dvddemux name=dvd dvd. ! mpeg2dec ! queue ! ffmpegcolorspace ! xvimagesink dvd. ! a52dec ! audioconvert ! audioresample ! queue ! osssink Setting pipeline to PAUSED ... No accelerated IMDCT transform found libdvdread: Using libdvdcss version 1.2.9 for DVD access libdvdread: Invalid main menu IFO (VIDEO_TS.IFO). ERROR: Pipeline doesn't want to pause. ERROR: from element /pipeline0/dvdreadsrc0: Could not open DVD Additional debug info: dvdreadsrc.c(236): gst_dvd_read_src_start (): /pipeline0/dvdreadsrc0: ifoOpen() failed: File exists Setting pipeline to NULL ... FREEING pipeline ... [...] === https://bugzilla.redhat.com/show_bug.cgi?id=442508 Regards, R. -- Fedora contributor http://fedoraproject.org/wiki/DominikMierzejewski Livna contributor http://rpm.livna.org MPlayer developer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"

3 20

libdvdread and DVDFileStat
by Benjamin Drung 26 Feb '09

26 Feb '09

Hello, dvdbackup [1] uses DVDFileStat exported from dvd_reader.h in libdvdread 0.9.6 [2] and 0.9.7 [3]. But libdvdread 4.1.3 from mplayer does not export this function. Can mplayer sync libdvdread 0.9.7 from ogle or add this function? Regards, Benjamin Drung PS: I have send this mail on 2008-11-30 to this list, but the mail never appears in the mailing list archive. Now I have subscribed the mailing list. [1] http://dvdbackup.sourceforge.net/ [2] http://www.dtek.chalmers.se/groups/dvd/olddownloads.shtml [3] http://www.dtek.chalmers.se/groups/dvd/dist/libdvdread-0.9.7.tar.gz

4 5

r1168 - in trunk/libdvdread: msvc/include/pthreads/pthread.h msvc/include/sys/time.h msvc/include/unistd.h src/dvd_reader.c src/ifo_print.c
by nicodvb 15 Feb '09

15 Feb '09

Author: nicodvb Date: Sun Feb 15 19:30:24 2009 New Revision: 1168 Log: spelling fixes by Erik Hovland Modified: trunk/libdvdread/msvc/include/pthreads/pthread.h trunk/libdvdread/msvc/include/sys/time.h trunk/libdvdread/msvc/include/unistd.h trunk/libdvdread/src/dvd_reader.c trunk/libdvdread/src/ifo_print.c Modified: trunk/libdvdread/msvc/include/pthreads/pthread.h ============================================================================== --- trunk/libdvdread/msvc/include/pthreads/pthread.h Mon Feb 2 23:55:58 2009 (r1167) +++ trunk/libdvdread/msvc/include/pthreads/pthread.h Sun Feb 15 19:30:24 2009 (r1168) @@ -196,7 +196,7 @@ extern "C" * pthread_attr_setstackaddr * * _POSIX_THREAD_PRIORITY_SCHEDULING (set) - * If set, you can use realtime scheduling. + * If set, you can use real-time scheduling. * Indicates the availability of: * pthread_attr_getinheritsched * pthread_attr_getschedparam @@ -393,7 +393,7 @@ enum { PTHREAD_SCOPE_SYSTEM = 1, /* Default */ /* - * pthread_setcancelstate paramters + * pthread_setcancelstate parameters */ PTHREAD_CANCEL_ENABLE = 0, /* Default */ PTHREAD_CANCEL_DISABLE = 1, @@ -420,7 +420,7 @@ enum { /* * ==================== * ==================== - * Cancelation + * Cancellation * ==================== * ==================== */ Modified: trunk/libdvdread/msvc/include/sys/time.h ============================================================================== --- trunk/libdvdread/msvc/include/sys/time.h Mon Feb 2 23:55:58 2009 (r1167) +++ trunk/libdvdread/msvc/include/sys/time.h Sun Feb 15 19:30:24 2009 (r1168) @@ -20,7 +20,7 @@ * WIN32 PORT, * by Matthew Grooms <elon(a)altavista.com> * - * sys/time.h - There is no seperate sys/time.h for win32 so we simply + * sys/time.h - There is no separate sys/time.h for win32 so we simply * include the standard time header as well as our xine * timer functions. */ Modified: trunk/libdvdread/msvc/include/unistd.h ============================================================================== --- trunk/libdvdread/msvc/include/unistd.h Mon Feb 2 23:55:58 2009 (r1167) +++ trunk/libdvdread/msvc/include/unistd.h Sun Feb 15 19:30:24 2009 (r1168) @@ -21,7 +21,7 @@ * by Matthew Grooms <elon(a)altavista.com> * * unistd.h - This is mostly a catch all header that maps standard unix - * libc calls to the equivelent win32 functions. + * libc calls to the equivalent win32 functions. * */ @@ -63,7 +63,7 @@ #define snprintf _snprintf #define vsnprintf _vsnprintf -// FIXME : I dont remember why this is here +// FIXME : I don't remember why this is here #define readlink #endif Modified: trunk/libdvdread/src/dvd_reader.c ============================================================================== --- trunk/libdvdread/src/dvd_reader.c Mon Feb 2 23:55:58 2009 (r1167) +++ trunk/libdvdread/src/dvd_reader.c Sun Feb 15 19:30:24 2009 (r1168) @@ -249,7 +249,7 @@ static dvd_reader_t *DVDOpenImageFile( c if( have_css ) { /* Only if DVDCSS_METHOD = title, a bit if it's disc or if - * DVDCSS_METHOD = key but region missmatch. Unfortunaly we + * DVDCSS_METHOD = key but region mismatch. Unfortunately we * don't have that information. */ dvd->css_state = 1; /* Need key init. */ @@ -304,7 +304,7 @@ static char *sun_block2char( const char #endif #if defined(SYS_BSD) -/* FreeBSD /dev/(r)(a)cd0c (a is for atapi), recomended to _not_ use r +/* FreeBSD /dev/(r)(a)cd0c (a is for atapi), recommended to _not_ use r OpenBSD /dev/rcd0c, it needs to be the raw device NetBSD /dev/rcd0[d|c|..] d for x86, c (for non x86), perhaps others Darwin /dev/rdisk0, it needs to be the raw device @@ -415,7 +415,7 @@ dvd_reader_t *DVDOpen( const char *ppath #ifndef WIN32 /* don't have fchdir, and getcwd( NULL, ... ) is strange */ /* Also WIN32 does not have symlinks, so we don't need this bit of code. */ - /* Resolve any symlinks and get the absolut dir name. */ + /* Resolve any symlinks and get the absolute dir name. */ { char *new_path; int cdir = open( ".", O_RDONLY ); @@ -438,7 +438,7 @@ dvd_reader_t *DVDOpen( const char *ppath /** * If we're being asked to open a directory, check if that directory - * is the mountpoint for a DVD-ROM which we can use instead. + * is the mount point for a DVD-ROM which we can use instead. */ if( strlen( path_copy ) > 1 ) { Modified: trunk/libdvdread/src/ifo_print.c ============================================================================== --- trunk/libdvdread/src/ifo_print.c Mon Feb 2 23:55:58 2009 (r1167) +++ trunk/libdvdread/src/ifo_print.c Sun Feb 15 19:30:24 2009 (r1168) @@ -130,7 +130,7 @@ static void ifo_print_video_attributes(i printf("(please send a bug report), "); } - // Wide is allways allowed..!!! + // Wide is always allowed..!!! switch(attr->permitted_df) { case 0: printf("pan&scan+letterboxed, "); @@ -328,7 +328,7 @@ static void ifo_print_audio_attributes(i case 1: // Normal audio printf("Normal Caption "); break; - case 2: // visually imparied + case 2: // visually impaired printf("Audio for visually impaired "); break; case 3: // Directors 1 @@ -685,7 +685,7 @@ static void ifoPrint_CELL_PLAYBACK(cell_ break; case 2: case 3: - printf("(send bug repport) "); + printf("(send bug report) "); break; } } @@ -781,7 +781,7 @@ void ifoPrint_PGC(pgc_t *pgc) { } } - /* Memmory offsets to div. tables. */ + /* Memory offsets to div. tables. */ ifoPrint_PGC_COMMAND_TBL(pgc->command_tbl); ifoPrint_PGC_PROGRAM_MAP(pgc->program_map, pgc->nr_of_programs); ifoPrint_CELL_PLAYBACK(pgc->cell_playback, pgc->nr_of_cells); @@ -806,7 +806,7 @@ void ifoPrint_TT_SRPT(tt_srpt_t *tt_srpt printf("\tTitle playback type: (%02x)\n", *(uint8_t *)&(tt_srpt->title[i].pb_ty)); printf("\t\t%s\n", - tt_srpt->title[i].pb_ty.multi_or_random_pgc_title ? "Random or Shuffle" : "Sequencial"); + tt_srpt->title[i].pb_ty.multi_or_random_pgc_title ? "Random or Shuffle" : "Sequential"); if (tt_srpt->title[i].pb_ty.jlc_exists_in_cell_cmd) printf("\t\tJump/Link/Call exists in cell cmd\n"); if (tt_srpt->title[i].pb_ty.jlc_exists_in_prepost_cmd) printf("\t\tJump/Link/Call exists in pre/post cmd\n"); if (tt_srpt->title[i].pb_ty.jlc_exists_in_button_cmd) printf("\t\tJump/Link/Call exists in button cmd\n"); @@ -1109,7 +1109,7 @@ void ifo_print(dvd_reader_t *dvd, int ti printf("No PGCI Unit table present\n"); } - printf("\nParental Manegment Information table\n"); + printf("\nParental Management Information table\n"); printf( "------------------------------------\n"); if(ifohandle->ptl_mait) { ifoPrint_PTL_MAIT(ifohandle->ptl_mait); @@ -1129,12 +1129,12 @@ void ifo_print(dvd_reader_t *dvd, int ti printf("No Text Data Manager Information present\n"); } - printf("\nMenu Cell Adress table\n"); + printf("\nMenu Cell Address table\n"); printf( "-----------------\n"); if(ifohandle->menu_c_adt) { ifoPrint_C_ADT(ifohandle->menu_c_adt); } else { - printf("No Menu Cell Adress table present\n"); + printf("No Menu Cell Address table present\n"); } printf("\nVideo Manager Menu VOBU address map\n"); @@ -1176,12 +1176,12 @@ void ifo_print(dvd_reader_t *dvd, int ti printf("No VTS Time Map table present\n"); } - printf("\nMenu Cell Adress table\n"); + printf("\nMenu Cell Address table\n"); printf( "-----------------\n"); if(ifohandle->menu_c_adt) { ifoPrint_C_ADT(ifohandle->menu_c_adt); } else { - printf("No Cell Adress table present\n"); + printf("No Cell Address table present\n"); } printf("\nVideo Title Set Menu VOBU address map\n");

1 0

[PATCH] Itty bitty resource leak
by Erik Hovland 14 Feb '09

14 Feb '09

One patch, an ifo handle might be leaked in the error path. E --- Erik Hovland (1): It is possible to leak an ifo handle in an error path in searching.c src/searching.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) -- Erik Hovland mail: erik(a)hovland.org web: http://hovland.org/ PGP/GPG public key available on request

1 1

dvdbackup and the skipping unused/bad sectors patch
by Benjamin Drung 09 Feb '09

09 Feb '09

Hi, Don Mahurin has modified [1] dvdbackup [2] to find and avoid unused blocks by following title set titles, and then skips the unused blocks. The purpose of this modification is to avoid possible bad sectors that sometimes occur, by manufacturer defect or intention, in unused regions of the disc. The titleset titles are followed using libdvdread and "libdvdvm" extracted from libdvdnav. The "libdvdvm" parts are not perfect, as some jump instructions are skipped to avoid the actual execution of the Jump, which fails in this isolated use of the library. It would be nice if this "libdvdnav" could be separated from libdvdnav into a standalone library. In libdvdnav 4.1.3 there is already an directory called vm. [1] http://dvdbackupx.openright.org/ [2] http://dvdbackup.sourceforge.net/ Regards, Benjamin Drung

2 1

Re: [DVDnav-discuss] Fwd: Patch to add dvdnav_get_serial_string function to dvdnav
by Nico Sabbi 02 Feb '09

02 Feb '09

> > > > ---------- Messaggio inoltrato ---------- > From: Matthew Wire <devel(a)mrwire.co.uk> > To: dvdnav mailing list <dvdnav-discuss(a)mplayerhq.hu> > Date: Wed, 28 Jan 2009 12:53:11 +0000 > Subject: [DVDnav-discuss] Patch to add dvdnav_get_serial_string > function to dvdnav > The attached patch adds a function to dvdnav to obtain the dvd serial > number externally. > > This is used in mythtv to generate a unique id for the disc for it's > bookmarking code. > > This is my first patch to dvdnav to please tell me if I'm doing things > wrong etc. > > Cheers, > Matthew > you broke the API extending an existing function for no reason; you should add a new function and raise the minor number instead. >

3 4

r1167 - in trunk/libdvdnav/src: dvdnav.c dvdnav/dvdnav.h vm/vm.c vm/vm.h
by nicodvb 02 Feb '09

02 Feb '09

Author: nicodvb Date: Mon Feb 2 23:55:58 2009 New Revision: 1167 Log: implement and export dvdnav_get_serial_string(); patch by Matthew Wire devel - mrwire - co - uk. Fixed by Erik Modified: trunk/libdvdnav/src/dvdnav.c trunk/libdvdnav/src/dvdnav/dvdnav.h trunk/libdvdnav/src/vm/vm.c trunk/libdvdnav/src/vm/vm.h Modified: trunk/libdvdnav/src/dvdnav.c ============================================================================== --- trunk/libdvdnav/src/dvdnav.c Mon Jan 12 13:10:32 2009 (r1166) +++ trunk/libdvdnav/src/dvdnav.c Mon Feb 2 23:55:58 2009 (r1167) @@ -825,6 +825,11 @@ dvdnav_status_t dvdnav_get_title_string( return DVDNAV_STATUS_OK; } +dvdnav_status_t dvdnav_get_serial_string(dvdnav_t *this, const char **serial_str) { + (*serial_str) = this->vm->dvd_serial; + return DVDNAV_STATUS_OK; +} + uint8_t dvdnav_get_video_aspect(dvdnav_t *this) { uint8_t retval; Modified: trunk/libdvdnav/src/dvdnav/dvdnav.h ============================================================================== --- trunk/libdvdnav/src/dvdnav/dvdnav.h Mon Jan 12 13:10:32 2009 (r1166) +++ trunk/libdvdnav/src/dvdnav/dvdnav.h Mon Feb 2 23:55:58 2009 (r1167) @@ -537,6 +537,13 @@ dvdnav_status_t dvdnav_spu_language_sele dvdnav_status_t dvdnav_get_title_string(dvdnav_t *self, const char **title_str); /* + * Returns a string containing the serial number of the DVD. + * This has a max of 15 characters and should be more unique than the + * title string. + */ +dvdnav_status_t dvdnav_get_serial_string(dvdnav_t *self, const char **serial_str); + +/* * Get video aspect code. * The aspect code does only change on VTS boundaries. * See the DVDNAV_VTS_CHANGE event. Modified: trunk/libdvdnav/src/vm/vm.c ============================================================================== --- trunk/libdvdnav/src/vm/vm.c Mon Jan 12 13:10:32 2009 (r1166) +++ trunk/libdvdnav/src/vm/vm.c Mon Feb 2 23:55:58 2009 (r1167) @@ -156,7 +156,7 @@ static int os2_open(const char *name, in } #endif -static void dvd_read_name(char *name, const char *device) { +static void dvd_read_name(char *name, char *serial, const char *device) { /* Because we are compiling with _FILE_OFFSET_BITS=64 * all off_t are 64bit. */ @@ -192,6 +192,8 @@ static void dvd_read_name(char *name, co fprintf(MSG_OUT, " "); } } + strncpy(serial, (char*) &data[73], (i-73)); + serial[14] = 0; fprintf(MSG_OUT, "\nlibdvdnav: DVD Title (Alternative): "); for(i=89; i < 128; i++ ) { if((data[i] == 0)) break; @@ -352,7 +354,7 @@ int vm_reset(vm_t *vm, const char *dvdro fprintf(MSG_OUT, "libdvdnav: vm: failed to open/read the DVD\n"); return 0; } - dvd_read_name(vm->dvd_name, dvdroot); + dvd_read_name(vm->dvd_name, vm->dvd_serial, dvdroot); vm->map = remap_loadmap(vm->dvd_name); vm->vmgi = ifoOpenVMGI(vm->dvd); if(!vm->vmgi) { Modified: trunk/libdvdnav/src/vm/vm.h ============================================================================== --- trunk/libdvdnav/src/vm/vm.h Mon Jan 12 13:10:32 2009 (r1166) +++ trunk/libdvdnav/src/vm/vm.h Mon Feb 2 23:55:58 2009 (r1167) @@ -82,6 +82,7 @@ typedef struct { dvd_state_t state; int32_t hop_channel; char dvd_name[50]; + char dvd_serial[15]; remap_t *map; int stopped; } vm_t;

1 0

Extended API
by Jorgen Lundman 02 Feb '09

02 Feb '09

As a first time developer using libdvdnav, it is quite straight forward to work with, and hides most of the magic required to read DVDs. It is quite straight forward to enumerate the audio streams, and SPU sub channels. Pick the title I want to "play", ie; receive data for and start. But I feel the API is a bit lacking. It seems to always send me the full-stream when I play,for example, title 2. This forces me to delve rather deep into MPEG specifics after all. I expected to find API calls to be able to do this: dvdnav_title_play(dvdnav, 2); // play title 2 + dvdnav_set_audio_stream(dvdnav, 3); // select audio stream 3 + dvdnav_set_spu_stream(dvdnav, 1); // pick subs stream 1 while(dvdnav_get_next_cache_block) { case DVDNAV_BLOCK_OK: // we got blocks related to title 1, audio 3 and spu 1. I can understand most software using libdvdnav already have MPG demuxers so it makes little difference, most of them seems to have been forced to add demux code anyway. It really would have been nice if libdvdnav went the whole way. :) It didn't say I was shopping at IKEA... Anyway, anyone have a nice example to pull out only the video, audio and spu stream that I want? It seems I have lots to learn about MPEG packets. Lund -- Jorgen Lundman | <lundman(a)lundman.net> Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work) Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell) Japan | +81 (0)3 -3375-1767 (home)

2 1