November 2009 - DVDnav-discuss - lists.mplayerhq.hu

[PATCH] consuming all memory when scanning dvd "Up"
by John Stebbins 09 Dec '12

09 Dec '12

First a disclaimer. This is a big invasive patch. If you don't like it, my feelings won't be hurt. I will be using it in HandBrake. So if you see problems with it, please let me know. Many dvd's are showing up that have titles that have numerous repeated language unit tables and pgc's. The new release "Up" is an example. I believe "Dark Knight" also exhibits this. When scanning such discs with lsdvd (and other programs that scan all titles), libdvdread will consume many GB of data for these repeated elements and gets very slow (e.g hours to read all titles) on OS X due to reading the duplicate data from uncached raw devices. This patch detects duplicates and reference counts pgc's and pgcit's. When a duplicate is detected, a reference count is incremented instead of allocating new memory and re-reading the data. I opted for reference counting instead of simply returning a failure on duplicate detection because it is perfectly valid to have a title with such duplicates. I could easily imagine titles adding duplicates, then navigating around them.

3 5

[PATCH 0/6] catch up to 0.9.6 and a couple of extras
by Erik Hovland 10 Oct '11

10 Oct '11

In an attempt to work towards getting Jorgen's patches in, I have taken on the task of catching up the mplayer tree of libdvdread to 0.9.6. Next will be 0.9.7. But I figured that I can submit that in its own chunk. This patch set also includes some cosmetic fixes as well as a potential memory leak fix and a check of a few system calls. Enjoy E --- Erik Hovland (6): 0.9.6 included a few items to improve the sofware on the *BSD Add in DVDFileStat Add the version function DVDVersion(). The version should be bumped to at least 5. But I am going to go to 6 on this one. Make cosmetic changes to files. Some system calls that report errors are not being checked. msvc/include/pthreads/pthread.h | 6 - msvc/include/sys/time.h | 2 msvc/include/unistd.h | 4 - src/bitreader.c | 2 src/dvd_input.c | 2 src/dvd_reader.c | 258 ++++++++++++++++++++++++++++++++++++--- src/dvd_udf.c | 4 - src/dvdread/dvd_reader.h | 47 ++++++- src/dvdread/ifo_types.h | 2 src/dvdread/nav_types.h | 8 + src/ifo_print.c | 22 ++- src/md5.c | 4 - src/nav_print.c | 2 13 files changed, 302 insertions(+), 61 deletions(-) -- Signature

7 34

[PATCH] UDF2.50 part 1
by Jorgen Lundman 06 Oct '11

06 Oct '11

Separated RAR support, as it is the most questionble change in the old patch. Told emacs to never use tabs too, so it should be cleaner. Add UDF2.50 logic, which includes BD5ISO, and HD-DVD support. Support non-DVD style access. (File iteration, and reading). Diffed against svn 1153. This patch includes: 1. Add ExtFinfo (262) support 2. Add FileType (250) re-direct support 3. DVDOpendir/DVDReaddir/DVDClosedir/DVDOpenFile for UDF access. 4. dvdread-1.9.7 stat methods for obtaining VOB data and sizes 5. AD chaining, instead of assuming files will always fit in 1 AD group. 6. dvd_udf API uses "UDF_FILE" type instead of "starting block number". 7. Separate struct AD and struct FileAD instead of ugly 64->32 bit work. 8. Minor memory clearing problems, and memory leaks. Lund -- Jorgen Lundman | <lundman(a)lundman.net> Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work) Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell) Japan | +81 (0)3 -3375-1767 (home) -- Jorgen Lundman | <lundman(a)lundman.net> Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work) Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell) Japan | +81 (0)3 -3375-1767 (home) -- Jorgen Lundman | <lundman(a)lundman.net> Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work) Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell) Japan | +81 (0)3 -3375-1767 (home)

6 35

[PATCH] crash while processing mac the ripper "feature title extract" images
by John Stebbins 06 Oct '11

06 Oct '11

Mac the ripper's feature title extraction removes menus from the resulting image, but does not remove navigation instructions that attempt to jump to those menus. This patch checks that a menu exists before acting on such instructions. If the menu does not exist, the it puts the vm into the stopped state.

3 6

"libdvdread: Invalid main menu IFO" on ppc
by Dominik 'Rathann' Mierzejewski 05 Mar '10

05 Mar '10

I've just received a bug report: === Opened by W. Michael Petullo on 2008-04-15 04:11 EST [reply] Description of problem: I have been unable to play DVD's with gstreamer-plugins-ugly-0.10.7-1.lvn9.ppc when it is built against libdvdread-4.1.1-6.fc9.ppc. I rebuilt gstreamer-plugins-ugly against the older libdvdread-0.9.7-3.fc8 and it worked fine. I receive an error that states, "libdvdread: Invalid main menu IFO (VIDEO_TS.IFO)." Here is an example: > gst-launch dvdreadsrc device=/dev/hdc ! dvddemux name=dvd dvd. ! mpeg2dec ! queue ! ffmpegcolorspace ! xvimagesink dvd. ! a52dec ! audioconvert ! audioresample ! queue ! osssink Setting pipeline to PAUSED ... No accelerated IMDCT transform found libdvdread: Using libdvdcss version 1.2.9 for DVD access libdvdread: Invalid main menu IFO (VIDEO_TS.IFO). ERROR: Pipeline doesn't want to pause. ERROR: from element /pipeline0/dvdreadsrc0: Could not open DVD Additional debug info: dvdreadsrc.c(236): gst_dvd_read_src_start (): /pipeline0/dvdreadsrc0: ifoOpen() failed: File exists Setting pipeline to NULL ... FREEING pipeline ... [...] === https://bugzilla.redhat.com/show_bug.cgi?id=442508 Regards, R. -- Fedora contributor http://fedoraproject.org/wiki/DominikMierzejewski Livna contributor http://rpm.livna.org MPlayer developer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"

3 20

r1187 - trunk/libdvdnav/ChangeLog
by rathann 14 Nov '09

14 Nov '09

Author: rathann Date: Sat Nov 14 22:03:35 2009 New Revision: 1187 Log: Update ChangeLog for next release. Modified: trunk/libdvdnav/ChangeLog Modified: trunk/libdvdnav/ChangeLog ============================================================================== --- trunk/libdvdnav/ChangeLog Sat Nov 14 22:00:17 2009 (r1186) +++ trunk/libdvdnav/ChangeLog Sat Nov 14 22:03:35 2009 (r1187) @@ -1,3 +1,8 @@ +libdvdnav (4.1.4) + * OS/2 support + * added dvdnav_get_serial_string() function + * fixed ifo leak in dvdnav_describe_chapters() + libdvdnav (4.1.3) * an embarassing amount of fixes regarding potential memory and resource leaks (patches contributed by Erik Hovland)

1 0

r1186 - trunk/libdvdread/ChangeLog
by rathann 14 Nov '09

14 Nov '09

Author: rathann Date: Sat Nov 14 22:00:17 2009 New Revision: 1186 Log: Update ChangeLog for next release. Modified: trunk/libdvdread/ChangeLog Modified: trunk/libdvdread/ChangeLog ============================================================================== --- trunk/libdvdread/ChangeLog Sat Nov 14 21:59:38 2009 (r1185) +++ trunk/libdvdread/ChangeLog Sat Nov 14 22:00:17 2009 (r1186) @@ -1,3 +1,9 @@ +libdvdread (4.1.4) + * added OS/2 support + * fixed ARM memory alignment issue + * portability fixes for *BSD, Mac OS X and MINGW + * added a missing DVDFileStat function + libdvdread (4.1.3) * an embarassing amount of fixes regarding potential memory and resource leaks (patches contributed by Erik Hovland)

1 0

r1185 - trunk/libdvdread/ChangeLog
by rathann 14 Nov '09

14 Nov '09

Author: rathann Date: Sat Nov 14 21:59:38 2009 New Revision: 1185 Log: Remove trailing whitespace. Modified: trunk/libdvdread/ChangeLog Modified: trunk/libdvdread/ChangeLog ============================================================================== --- trunk/libdvdread/ChangeLog Sun Sep 27 00:44:38 2009 (r1184) +++ trunk/libdvdread/ChangeLog Sat Nov 14 21:59:38 2009 (r1185) @@ -114,7 +114,7 @@ libdvdnav (0.1.0-1.1) unstable; urgency= (see patch from Jamie Wilkinson for a better solution) -- Siggi Langauf <siggi(a)debian.org> Mon, 20 May 2002 15:57:40 +0200 - + libdvdnav (0.0.1-1) unstable; urgency=low * Repackaged using dh-make.

1 0