April 2008 - DVDnav-discuss - lists.mplayerhq.hu

"libdvdread: Invalid main menu IFO" on ppc
by Dominik 'Rathann' Mierzejewski 05 Mar '10

05 Mar '10

I've just received a bug report: === Opened by W. Michael Petullo on 2008-04-15 04:11 EST [reply] Description of problem: I have been unable to play DVD's with gstreamer-plugins-ugly-0.10.7-1.lvn9.ppc when it is built against libdvdread-4.1.1-6.fc9.ppc. I rebuilt gstreamer-plugins-ugly against the older libdvdread-0.9.7-3.fc8 and it worked fine. I receive an error that states, "libdvdread: Invalid main menu IFO (VIDEO_TS.IFO)." Here is an example: > gst-launch dvdreadsrc device=/dev/hdc ! dvddemux name=dvd dvd. ! mpeg2dec ! queue ! ffmpegcolorspace ! xvimagesink dvd. ! a52dec ! audioconvert ! audioresample ! queue ! osssink Setting pipeline to PAUSED ... No accelerated IMDCT transform found libdvdread: Using libdvdcss version 1.2.9 for DVD access libdvdread: Invalid main menu IFO (VIDEO_TS.IFO). ERROR: Pipeline doesn't want to pause. ERROR: from element /pipeline0/dvdreadsrc0: Could not open DVD Additional debug info: dvdreadsrc.c(236): gst_dvd_read_src_start (): /pipeline0/dvdreadsrc0: ifoOpen() failed: File exists Setting pipeline to NULL ... FREEING pipeline ... [...] === https://bugzilla.redhat.com/show_bug.cgi?id=442508 Regards, R. -- Fedora contributor http://fedoraproject.org/wiki/DominikMierzejewski Livna contributor http://rpm.livna.org MPlayer developer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"

3 20

r1015 - in trunk/libdvdnav: Makefile misc/dvdread-config.sh
by nicodvb 13 Jul '08

13 Jul '08

Author: nicodvb Date: Sat Apr 19 22:18:35 2008 New Revision: 1015 Log: added dvdread-config. Hopefully I didn't make a mess with svn cp Added: trunk/libdvdnav/misc/dvdread-config.sh - copied, changed from r1001, /trunk/libdvdnav/misc/dvdnav-config2.sh Modified: trunk/libdvdnav/Makefile Modified: trunk/libdvdnav/Makefile ============================================================================== --- trunk/libdvdnav/Makefile (original) +++ trunk/libdvdnav/Makefile Sat Apr 19 22:18:35 2008 @@ -60,13 +60,13 @@ DVDREAD_DEPS= ${DVDREAD_OBJS:%.o=%.d} BUILDDEPS = Makefile config.mak ifeq ($(BUILD_SHARED),yes) -all: $(SHLIB) $(MINI_SHLIB) $(DVDREAD_SHLIB) dvdnav-config -install: $(SHLIB) $(DVDREAD_SHLIB) install-shared install-dvdnav-config +all: $(SHLIB) $(MINI_SHLIB) $(DVDREAD_SHLIB) dvdnav-config dvdread-config +install: $(SHLIB) $(DVDREAD_SHLIB) install-shared install-dvdnav-config install-dvdread-config endif ifeq ($(BUILD_STATIC),yes) -all: $(LIB) $(DVDREAD_LIB) dvdnav-config -install: $(LIB) $(DVDREAD_LIB) install-static install-dvdnav-config +all: $(LIB) $(DVDREAD_LIB) dvdnav-config dvdread-config +install: $(LIB) $(DVDREAD_LIB) install-static install-dvdnav-config install-dvdread-config endif install: install-headers @@ -188,6 +188,18 @@ install-dvdnav-config: dvdnav-config install -d $(DESTDIR)$(PREFIX)/bin install -m 0755 $(.OBJDIR)/dvdnav-config $(DESTDIR)$(PREFIX)/bin/dvdnav-config +dvdread-config: $(.OBJDIR) + @echo '#!/bin/sh' > $(.OBJDIR)/dvdread-config + @echo 'prefix='$(PREFIX) >> $(.OBJDIR)/dvdread-config + @echo 'libdir='$(shlibdir) >> $(.OBJDIR)/dvdread-config + @echo 'version='$(SHLIB_VERSION) >> $(.OBJDIR)/dvdread-config + @echo >> $(.OBJDIR)/dvdread-config + cat $(SRC_PATH_BARE)/misc/dvdread-config.sh >> $(.OBJDIR)/dvdread-config + chmod 0755 $(.OBJDIR)/dvdread-config + +install-dvdread-config: dvdread-config + install -d $(DESTDIR)$(PREFIX)/bin + install -m 0755 $(.OBJDIR)/dvdread-config $(DESTDIR)$(PREFIX)/bin/dvdread-config vpath %.so ${.OBJDIR} vpath %.o ${.OBJDIR} Copied: trunk/libdvdnav/misc/dvdread-config.sh (from r1001, /trunk/libdvdnav/misc/dvdnav-config2.sh) ============================================================================== --- /trunk/libdvdnav/misc/dvdnav-config2.sh (original) +++ trunk/libdvdnav/misc/dvdread-config.sh Sat Apr 19 22:18:35 2008 @@ -1,21 +1,14 @@ dvdreadlib="-ldvdread" -dvdreadmsg="[--minilibs]" -if test "$dvdread" = "external"; then - dvdreadmsg="[--minicflags]" - dvdreadcflags="-I$dvdreaddir" - extracflags="-DDVDNAV_USES_EXTERNAL_DVDREAD" -fi usage() { cat <<EOF -Usage: dvdnav-config [OPTIONS] [LIBRARIES] +Usage: dvdread-config [OPTIONS] [LIBRARIES] Options: [--prefix[=DIR]] [--version] [--libs] [--cflags] - $dvdreadmsg EOF exit $1 } @@ -40,19 +33,9 @@ while test $# -gt 0; do --cflags) echo_cflags=yes ;; - --minicflags) - if test "$dvdread" = "external"; then - echo_minicflags=yes - else - usage 1 1>&2 - fi - ;; --libs) echo_libs=yes ;; - --minilibs) - echo_minilibs=yes - ;; *) usage 1 1>&2 ;; @@ -65,17 +48,9 @@ if test "$echo_prefix" = "yes"; then fi if test "$echo_cflags" = "yes"; then - echo -I$prefix/include $dvdreadcflags $extracflags $threadcflags -fi - -if test "$echo_minicflags" = "yes"; then - echo -I$prefix/include -I$prefix/include/dvdnav $extracflags $threadcflags + echo -I$prefix/include $extracflags fi if test "$echo_libs" = "yes"; then - echo -L$libdir -ldvdnav $dvdreadlib $threadlib + echo -L$libdir $dvdreadlib fi - -if test "$echo_minilibs" = "yes"; then - echo -L$libdir -ldvdnavmini $threadlib -fi

4 4

[PATCH] Fix parallel jobs; sources need version.h
by Dan Nicholson 01 May '08

01 May '08

--- Makefile | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index fcc3940..85108e5 100644 --- a/Makefile +++ b/Makefile @@ -81,6 +81,8 @@ endif version.h: sh $(SRC_PATH)/version.sh $(SRC_PATH) +$(SRCS) $(DVDREAD_SRCS): version.h + # General targets -- 1.5.3.2

2 5

[PATCH] Create version.h with released version number when SVN not known
by Dan Nicholson 28 Apr '08

28 Apr '08

--- Makefile | 2 +- version.sh | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 85108e5..c76c72c 100644 --- a/Makefile +++ b/Makefile @@ -79,7 +79,7 @@ version.h: $(SVN_ENTRIES) endif version.h: - sh $(SRC_PATH)/version.sh $(SRC_PATH) + sh $(SRC_PATH)/version.sh $(SRC_PATH) "$(SHLIB_VERSION)" $(SRCS) $(DVDREAD_SRCS): version.h diff --git a/version.sh b/version.sh index 6ef2323..6b4e52e 100755 --- a/version.sh +++ b/version.sh @@ -6,7 +6,11 @@ test $svn_revision || svn_revision=`cd "$1" && \ grep revision .svn/entries 2> /dev/null | cut -d '"' -f2 2> /dev/null` test $svn_revision || svn_revision=UNKNOWN -NEW_REVISION="#define VERSION \"SVN-r$svn_revision\"" +if test "$svn_revision" = UNKNOWN && test -n "$2"; then + NEW_REVISION="#define VERSION \"$2\"" +else + NEW_REVISION="#define VERSION \"SVN-r$svn_revision\"" +fi OLD_REVISION=`cat version.h 2> /dev/null` # Update version.h only on revision changes to avoid spurious rebuilds -- 1.5.3.2

1 0

[PATCH] Suppress error messages creating version.h from non-SVN checkout
by Dan Nicholson 28 Apr '08

28 Apr '08

--- version.sh | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/version.sh b/version.sh index be67dcd..6ef2323 100755 --- a/version.sh +++ b/version.sh @@ -1,8 +1,9 @@ #!/bin/sh -svn_revision=`cd "$1" && LC_ALL=C svn info 2> /dev/null | grep Revision | cut -d' ' -f2` -test $svn_revision || svn_revision=`cd "$1" && grep revision .svn/entries | \ - cut -d '"' -f2 2> /dev/null` +svn_revision=`cd "$1" && LC_ALL=C svn info 2> /dev/null | \ + grep Revision 2> /dev/null | cut -d' ' -f2` +test $svn_revision || svn_revision=`cd "$1" && \ + grep revision .svn/entries 2> /dev/null | cut -d '"' -f2 2> /dev/null` test $svn_revision || svn_revision=UNKNOWN NEW_REVISION="#define VERSION \"SVN-r$svn_revision\"" -- 1.5.3.2

1 0

r1020 - trunk/libdvdnav/src/dvdread/ifo_read.c
by nicodvb 27 Apr '08

27 Apr '08

Author: nicodvb Date: Sun Apr 27 11:53:45 2008 New Revision: 1020 Log: some debug message to identify the cause of 'Invalid main menu IFO' Modified: trunk/libdvdnav/src/dvdread/ifo_read.c Modified: trunk/libdvdnav/src/dvdread/ifo_read.c ============================================================================== --- trunk/libdvdnav/src/dvdread/ifo_read.c (original) +++ trunk/libdvdnav/src/dvdread/ifo_read.c Sun Apr 27 11:53:45 2008 @@ -121,7 +121,7 @@ ifo_handle_t *ifoOpen(dvd_reader_t *dvd, /* These are both mandatory. */ if(!ifoRead_FP_PGC(ifofile) || !ifoRead_TT_SRPT(ifofile)) { - fprintf(stderr, "libdvdread: Invalid main menu IFO (VIDEO_TS.IFO).\n"); + fprintf(stderr, "libdvdread: Invalid main menu IFO (VIDEO_TS.IFO), ifoRead_FP_PGC() failed.\n"); ifoClose(ifofile); return NULL; } @@ -131,7 +131,7 @@ ifo_handle_t *ifoOpen(dvd_reader_t *dvd, /* This is also mandatory. */ if(!ifoRead_VTS_ATRT(ifofile)) { - fprintf(stderr, "libdvdread: Invalid main menu IFO (VIDEO_TS.IFO).\n"); + fprintf(stderr, "libdvdread: Invalid main menu IFO (VIDEO_TS.IFO), ifoRead_VTS_ATRT() failed.\n"); ifoClose(ifofile); return NULL; } @@ -200,7 +200,7 @@ ifo_handle_t *ifoOpenVMGI(dvd_reader_t * if(ifoRead_VMG(ifofile)) return ifofile; - fprintf(stderr, "libdvdread: Invalid main menu IFO (VIDEO_TS.IFO).\n"); + fprintf(stderr, "libdvdread,ifoOpenVMGI(): Invalid main menu IFO (VIDEO_TS.IFO).\n"); ifoClose(ifofile); return NULL; }

1 0

r1018 - in trunk/libdvdnav/src: navigation.c vm/vm.c
by nicodvb 22 Apr '08

22 Apr '08

Author: nicodvb Date: Sun Apr 20 10:29:02 2008 New Revision: 1018 Log: in get_PGCIT() check the validity of vm->vtsi before risking to dereference NULL; also change dvdnav_get_current_menu() accordingly\npatch by Erik Hovland - erik hovland org Modified: trunk/libdvdnav/src/navigation.c trunk/libdvdnav/src/vm/vm.c Modified: trunk/libdvdnav/src/navigation.c ============================================================================== --- trunk/libdvdnav/src/navigation.c (original) +++ trunk/libdvdnav/src/navigation.c Sun Apr 20 10:29:02 2008 @@ -104,7 +104,10 @@ dvdnav_status_t dvdnav_current_title_inf if ( (this->vm->state.domain == VTSM_DOMAIN) || (this->vm->state.domain == VMGM_DOMAIN) ) { /* Get current Menu ID: into *part. */ - vm_get_current_menu(this->vm, part); + if(! vm_get_current_menu(this->vm, part)) { + pthread_mutex_unlock(&this->vm_lock); + return DVDNAV_STATUS_ERR; + } if (*part > -1) { *title = 0; pthread_mutex_unlock(&this->vm_lock); Modified: trunk/libdvdnav/src/vm/vm.c ============================================================================== --- trunk/libdvdnav/src/vm/vm.c (original) +++ trunk/libdvdnav/src/vm/vm.c Sun Apr 20 10:29:02 2008 @@ -1823,13 +1823,15 @@ static pgcit_t* get_MENU_PGCIT(vm_t *vm, /* Uses state to decide what to return */ static pgcit_t* get_PGCIT(vm_t *vm) { - pgcit_t *pgcit; + pgcit_t *pgcit = NULL; switch ((vm->state).domain) { case VTS_DOMAIN: + if(!vm->vtsi) return NULL; pgcit = vm->vtsi->vts_pgcit; break; case VTSM_DOMAIN: + if(!vm->vtsi) return NULL; pgcit = get_MENU_PGCIT(vm, vm->vtsi, (vm->state).registers.SPRM[0]); break; case VMGM_DOMAIN:

4 5

r1019 - trunk/libdvdnav/src/vm/vm.c
by nicodvb 22 Apr '08

22 Apr '08

Author: nicodvb Date: Tue Apr 22 09:36:49 2008 New Revision: 1019 Log: 10l to me: in vm_get_current_menu() I forgot to attach Erik's patch that returned 0 if get_PGCIT() fails Modified: trunk/libdvdnav/src/vm/vm.c Modified: trunk/libdvdnav/src/vm/vm.c ============================================================================== --- trunk/libdvdnav/src/vm/vm.c (original) +++ trunk/libdvdnav/src/vm/vm.c Tue Apr 22 09:36:49 2008 @@ -612,6 +612,7 @@ int vm_get_current_menu(vm_t *vm, int *m int pgcn; pgcn = (vm->state).pgcN; pgcit = get_PGCIT(vm); + if(pgcit==NULL) return 0; *menuid = pgcit->pgci_srp[pgcn - 1].entry_id & 0xf ; return 1; }

1 0

A few patches for minor defects
by Erik Hovland 21 Apr '08

21 Apr '08

I put the libdvdnav code in MythTV through a static analysis tool and it found some defects. I ported the patches I submitted there to the fork on mplayerhq. I offer them here to you in hopes you find them useful. E -- Erik Hovland mail: erik(a)hovland.org web: http://hovland.org/ PGP/GPG public key available on request

4 9

[propchange]: r1018 - svn:log
by nicodvb 20 Apr '08

20 Apr '08

Author: nicodvb Revision: 1018 Property Name: svn:log Action: modified Property diff: --- old property value +++ new property value @@ -1 +1,3 @@ -in get_PGCIT() check the validity of vm->vtsi before risking to dereference NULL; also change dvdnav_get_current_menu() accordingly\npatch by Erik Hovland - erik hovland org \ No newline at end of file +in get_PGCIT() check the validity of vm->vtsi before risking to dereference NULL; +also change dvdnav_get_current_menu() accordingly. +Patch by Erik Hovland - erik hovland org

1 0