August 2007 - DVDnav-discuss - lists.mplayerhq.hu

packaging libdvdnav and libdvdread and [PATCH]
by Dominik 'Rathann' Mierzejewski 19 Aug '07

19 Aug '07

Hi. As some of you might know, I'm responsible for creating RPM packages of some of our software, for example FFmpeg and MPlayer. Some time ago I took over packaging libdvdread and libdvdnav, too. I've already switched to this fork for dvdnav and seeing how things are, I'm preparing to switch to this dvdread as well, when it's forked. Do you have any pointers for packaging? Which dvdnav version should I use, libdvdnav or libdvdnav2? Will there be a website with tarballs? One more thing: it's been brought to my attention that compiling C++ code that uses dvdnav.h header fails, because "this" is a reserved word in C++. Patch attached. Regards, R. -- Fedora contributor http://fedoraproject.org/wiki/DominikMierzejewski Livna contributor http://rpm.livna.org MPlayer developer http://mplayerhq.hu "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"

2 3

r955 - in trunk: libdvdnav/src/dvdnav.h libdvdnav2/src/dvdnav.h
by rathann 19 Aug '07

19 Aug '07

Author: rathann Date: Sun Aug 19 23:25:04 2007 New Revision: 955 Log: - fix compilation of C++ code using dvdnav.h (this is a reserved C++ keyword) Modified: trunk/libdvdnav/src/dvdnav.h trunk/libdvdnav2/src/dvdnav.h Modified: trunk/libdvdnav/src/dvdnav.h ============================================================================== --- trunk/libdvdnav/src/dvdnav.h (original) +++ trunk/libdvdnav/src/dvdnav.h Sun Aug 19 23:25:04 2007 @@ -360,7 +360,7 @@ dvdnav_status_t dvdnav_sector_search(dvd returns the current stream time in PTS ticks as reported by the IFO structures divide it by 90000 to get the current play time in seconds */ -int64_t dvdnav_get_current_time(dvdnav_t *this); +int64_t dvdnav_get_current_time(dvdnav_t *self); /* * Stop playing the current position and start playback of the title Modified: trunk/libdvdnav2/src/dvdnav.h ============================================================================== --- trunk/libdvdnav2/src/dvdnav.h (original) +++ trunk/libdvdnav2/src/dvdnav.h Sun Aug 19 23:25:04 2007 @@ -364,7 +364,7 @@ dvdnav_status_t dvdnav_sector_search(dvd returns the current stream time in PTS ticks as reported by the IFO structures divide it by 90000 to get the current play time in seconds */ -int64_t dvdnav_get_current_time(dvdnav_t *this); +int64_t dvdnav_get_current_time(dvdnav_t *self); /* * Stop playing the current position and start playback of the title

1 0

[PATCH] promoting our dvdread
by Nico Sabbi 05 Aug '07

05 Aug '07

Given the insanity of the official dvdread (conditional bitfields et similia), and overflown by the amount of feedback received in the official ML ( 0 responses) , I decided that it's time to promote our baby monster (dvdread) as substitute for the elder (and worse) brother. The first thing to do is to enable compilation of the library as shared object, followed by a series of bugfix applications aimed at taking our dvdread up to par with 0.9.7 (excluding what wouldn't work, of course). Applying the patch attached dvdread will be build and installed as shared library system-wide and dvdnav will link against it. Please, if you want to test the compilation make sure to eradicate completely every instance of previous versions of dvdread, dvdnav, dvdnav-config and associated headers before the build. Please, help me to test the patch: I don't want to commit something disruptive for mplayer/vlc/xine. Any feedback is welcome. Thanks, Nico

2 4

r954 - in trunk/libdvdnav: misc/dvdnav-config.in src/dvdnav.h src/dvdread/Makefile.am
by nicodvb 05 Aug '07

05 Aug '07

Author: nicodvb Date: Sun Aug 5 22:27:59 2007 New Revision: 954 Log: dvdread is now built as independent library and installed system-wide alongside libdvdnav (it's intended to be a replacement for ogle's dvdread that is broken) Modified: trunk/libdvdnav/misc/dvdnav-config.in trunk/libdvdnav/src/dvdnav.h trunk/libdvdnav/src/dvdread/Makefile.am Modified: trunk/libdvdnav/misc/dvdnav-config.in ============================================================================== --- trunk/libdvdnav/misc/dvdnav-config.in (original) +++ trunk/libdvdnav/misc/dvdnav-config.in Sun Aug 5 22:27:59 2007 @@ -76,11 +76,11 @@ if test "$echo_exec_prefix" = "yes"; the fi if test "$echo_cflags" = "yes"; then - echo -I@includedir@ -I@includedir@/dvdnav @THREAD_CFLAGS@ + echo -I@includedir@ -I@includedir@/dvdnav -I@includedir@/dvdread @THREAD_CFLAGS@ fi if test "$echo_libs" = "yes"; then - echo -L@libdir@ -ldvdnav @THREAD_LIBS@ + echo -L@libdir@ -ldvdnav -ldvdread @THREAD_LIBS@ fi if test "$echo_minilibs" = "yes"; then Modified: trunk/libdvdnav/src/dvdnav.h ============================================================================== --- trunk/libdvdnav/src/dvdnav.h (original) +++ trunk/libdvdnav/src/dvdnav.h Sun Aug 5 22:27:59 2007 @@ -37,15 +37,9 @@ extern "C" { #ifndef DVDNAV_COMPILE # include <dvdnav/dvd_types.h> -#ifdef DVDNAV_USES_EXTERNAL_DVDREAD # include <dvdread/dvd_reader.h> # include <dvdread/nav_types.h> # include <dvdread/ifo_types.h> /* For vm_cmd_t */ -#else -# include <dvdnav/dvd_reader.h> -# include <dvdnav/nav_types.h> -# include <dvdnav/ifo_types.h> /* For vm_cmd_t */ -#endif # include <dvdnav/dvdnav_events.h> #endif Modified: trunk/libdvdnav/src/dvdread/Makefile.am ============================================================================== --- trunk/libdvdnav/src/dvdread/Makefile.am (original) +++ trunk/libdvdnav/src/dvdread/Makefile.am Sun Aug 5 22:27:59 2007 @@ -1,10 +1,10 @@ include $(top_srcdir)/misc/Makefile.common -includedir = ${prefix}/include/dvdnav +includedir = ${prefix}/include/dvdread AM_CPPFLAGS = -DDVDNAV_COMPILE -I$(top_srcdir)/src/vm -noinst_LTLIBRARIES = libdvdread.la +lib_LTLIBRARIES = libdvdread.la libdvdread_la_SOURCES = dvd_reader.c nav_read.c ifo_read.c \ dvd_input.c dvd_udf.c md5.c nav_print.c ifo_print.c \ @@ -12,5 +12,8 @@ libdvdread_la_SOURCES = dvd_reader.c nav libdvdread_la_LIBADD = $(DYNAMIC_LD_LIBS) +libdvdread_la_LDFLAGS = -version-info $(DVDNAV_LT_CURRENT):$(DVDNAV_LT_REVISION):$(DVDNAV_LT_AGE) \ + -export-symbols-regex "(^dvd.*|^nav.*|^ifo.*|^DVD.*)" + include_HEADERS = dvd_reader.h nav_read.h ifo_read.h \ nav_print.h ifo_print.h ifo_types.h nav_types.h

1 0

r953 - trunk/libdvdnav2/src/dvdread/ifo_print.c
by nicodvb 02 Aug '07

02 Aug '07

Author: nicodvb Date: Fri Aug 3 00:00:18 2007 New Revision: 953 Log: don't call dvdnav functions from within dvdread Modified: trunk/libdvdnav2/src/dvdread/ifo_print.c Modified: trunk/libdvdnav2/src/dvdread/ifo_print.c ============================================================================== --- trunk/libdvdnav2/src/dvdread/ifo_print.c (original) +++ trunk/libdvdnav2/src/dvdread/ifo_print.c Fri Aug 3 00:00:18 2007 @@ -71,7 +71,10 @@ static void ifo_print_cmd(int row, vm_cm for(i=0;i<8;i++) printf("%02x ", command->bytes[i]); printf("| "); +#if 0 + //disabled call of dvdnav function vm_print_mnemonic(command); +#endif printf("\n"); }

1 0

r952 - trunk/libdvdnav/src/dvdread/ifo_print.c
by nicodvb 02 Aug '07

02 Aug '07

Author: nicodvb Date: Thu Aug 2 23:58:59 2007 New Revision: 952 Log: don't call dvdnav functions from within dvdread Modified: trunk/libdvdnav/src/dvdread/ifo_print.c Modified: trunk/libdvdnav/src/dvdread/ifo_print.c ============================================================================== --- trunk/libdvdnav/src/dvdread/ifo_print.c (original) +++ trunk/libdvdnav/src/dvdread/ifo_print.c Thu Aug 2 23:58:59 2007 @@ -71,7 +71,10 @@ static void ifo_print_cmd(int row, vm_cm for(i=0;i<8;i++) printf("%02x ", command->bytes[i]); printf("| "); +#if 0 + //disabled call of dvdnav function vm_print_mnemonic(command); +#endif printf("\n"); }

1 0