July 2007 - DVDnav-discuss - lists.mplayerhq.hu

quick explanation needed
by gui42＠free.fr 29 Jul '07

29 Jul '07

Good morning As I compiled mplayer this weekend, I discovered dvdnav was under work again, so tried it. It compiles well (just one weird thing is that configure is called configure2), but it doesn't work any better with mplayer : I install libdvdnav on its own (making a package), and I then compile mplayer (for which I have to modify configure, line 7308, replace minilibs by libs, otherwise mplayer couldn't find dvdnav) but I get messages complaining that it can't find some reference in a function (sorry I didn't copy the messages). Could you please just modify the Install file so that everybody could know if there is anything special to do to compile libdvdnav itself and/or mplayer ? Thanks for your good work anyway, Have a nice day, Guillaume

4 9

[PATCH] incorrect exterrnal navRead_PCI
by Ötvös Attila 28 Jul '07

28 Jul '07

Hi All! If libdvdnavmini is used then result of the external navRead_PCI() is incorrect. The patch changes the navRead_PCI() to navRead_PCI_priv() and navRead_DSI() to navRead_DSI_priv() in nav_read_priv.c. This functions are in the libdvdnav and the lindvdnavmini too. The navRead_PCI() and navRead_DSI() functions only call to navRead_PCI_priv() and navRead_DSI_priv() in nav_read.c. Best regards! Attila

3 7

r951 - trunk/libdvdnav/misc/dvdnav-config2.sh
by nicodvb 28 Jul '07

28 Jul '07

Author: nicodvb Date: Sat Jul 28 11:53:58 2007 New Revision: 951 Log: 10l, --minilibs should report -ldvdnavmini Modified: trunk/libdvdnav/misc/dvdnav-config2.sh Modified: trunk/libdvdnav/misc/dvdnav-config2.sh ============================================================================== --- trunk/libdvdnav/misc/dvdnav-config2.sh (original) +++ trunk/libdvdnav/misc/dvdnav-config2.sh Sat Jul 28 11:53:58 2007 @@ -80,5 +80,5 @@ if test "$echo_libs" = "yes"; then fi if test "$echo_minilibs" = "yes"; then - echo -L$prefix/lib -ldvdnav $threadlib + echo -L$prefix/lib -ldvdnavmini $threadlib fi

1 0

[propchange]: r947 - svn:log
by nicodvb 14 Jul '07

14 Jul '07

Author: nicodvb Revision: 947 Property Name: svn:log Action: modified Property diff: --- old property value +++ new property value @@ -1 +1 @@ -make dvdnav_sector_search() work correctly for blocks in the last vobu; patch by ggurov+abc-bg \ No newline at end of file +make dvdnav_sector_search() work correctly for blocks in the last vobu; patch by ggurov+abv-bg \ No newline at end of file

1 0

[propchange]: r949 - svn:log
by nicodvb 14 Jul '07

14 Jul '07

Author: nicodvb Revision: 949 Property Name: svn:log Action: modified Property diff: --- old property value +++ new property value @@ -1 +1 @@ -make dvdnav_sector_search() work correctly for blocks in the last vobu; patch by ggurov+abc-bg \ No newline at end of file +make dvdnav_sector_search() work correctly for blocks in the last vobu; patch by ggurov+abv-bg \ No newline at end of file

1 0

Re: [DVDnav-discuss] Bugs in dvdnav_scan_admap
by Gospodin Gyurov 14 Jul '07

14 Jul '07

>> >> Also, this function always fails when it is used for blocks from the last VOBU. Due to this I prefer instead of the code after the 'while' loop: >> --------- >> if(found) { >> *vobu = vobu_start; >> return DVDNAV_STATUS_OK; >> } else { >> fprintf(MSG_OUT, "libdvdnav: Could not locate block\n"); >> return DVDNAV_STATUS_ERR; >> } >> --------- >> just this: >> >> *vobu = vobu_start; >> return DVDNAV_STATUS_OK; > >why does it fail in the last vobu? It sets "found = 1" only if "next_vobu > seekto_block". This comparison is not true for all blocks in the last vobu. Their addresses are >= from every possible next_vobu value. >I appreciate your contributions, but I'd love it you posted proper >patches :-) Frankly, I dont know how to do this :) Currently I work under Windows only. I'm old in programming but I'm new it this style of project's synchronization. Also, in the beginning ot my usage of dvdnav I made many changes (removing #include etc.) due to lots of errors when I tried to compile it with Borland C++ Builder 6. I was in time presure (and I'm still on) and I was unsure will I use this library in my project after the tests. In the beginning dvdnav didnt work for me at whole, due to its trials to read DVD blocks with file reading functions. I changed lots of things about this problem, I think under Windows reading from block devices must be done through Win API functions CreateFile and DeviceIoControl, not through C style io.h functions. After all my dvdnav version now is very different than the original, and I continue to make some changes which are in interest of my project only (it is VERY specific). I'm always ready to share the information about bugs etc, but I'm not sure can I use some patch utility in this case. ----------------------------------------------------------------- С бензин в кръвта! http://auto-motor-und-sport.bg/

2 1

r950 - trunk/libdvdnav2/src/searching.c
by nicodvb 14 Jul '07

14 Jul '07

Author: nicodvb Date: Sat Jul 14 13:29:04 2007 New Revision: 950 Log: a beauty mask Modified: trunk/libdvdnav2/src/searching.c Modified: trunk/libdvdnav2/src/searching.c ============================================================================== --- trunk/libdvdnav2/src/searching.c (original) +++ trunk/libdvdnav2/src/searching.c Sat Jul 14 13:29:04 2007 @@ -75,16 +75,13 @@ static dvdnav_status_t dvdnav_scan_admap /* fprintf(MSG_OUT, "libdvdnav: Found block %u\n", next_vobu); */ - if(vobu_start <= seekto_block && - next_vobu > seekto_block) { + if(vobu_start <= seekto_block && next_vobu > seekto_block) break; - } else { - vobu_start = next_vobu; - } - address ++; + vobu_start = next_vobu; + address++; } - *vobu = vobu_start; - return DVDNAV_STATUS_OK; + *vobu = vobu_start; + return DVDNAV_STATUS_OK; } fprintf(MSG_OUT, "libdvdnav: admap not located\n"); return DVDNAV_STATUS_ERR;

1 0

r949 - trunk/libdvdnav2/src/searching.c
by nicodvb 14 Jul '07

14 Jul '07

Author: nicodvb Date: Sat Jul 14 13:28:46 2007 New Revision: 949 Log: make dvdnav_sector_search() work correctly for blocks in the last vobu; patch by ggurov+abc-bg Modified: trunk/libdvdnav2/src/searching.c Modified: trunk/libdvdnav2/src/searching.c ============================================================================== --- trunk/libdvdnav2/src/searching.c (original) +++ trunk/libdvdnav2/src/searching.c Sat Jul 14 13:28:46 2007 @@ -65,32 +65,26 @@ static dvdnav_status_t dvdnav_scan_admap if(admap) { uint32_t address = 0; uint32_t vobu_start, next_vobu; - int32_t found = 0; int admap_entries = (admap->last_byte + 1 - VOBU_ADMAP_SIZE)/VOBU_ADMAP_SIZE; /* Search through ADMAP for best sector */ vobu_start = SRI_END_OF_CELL; /* FIXME: Implement a faster search algorithm */ - while((!found) && (address < admap_entries)) { + while(address < admap_entries) { next_vobu = admap->vobu_start_sectors[address]; /* fprintf(MSG_OUT, "libdvdnav: Found block %u\n", next_vobu); */ if(vobu_start <= seekto_block && next_vobu > seekto_block) { - found = 1; + break; } else { vobu_start = next_vobu; } address ++; } - if(found) { *vobu = vobu_start; return DVDNAV_STATUS_OK; - } else { - fprintf(MSG_OUT, "libdvdnav: Could not locate block\n"); - return DVDNAV_STATUS_ERR; - } } fprintf(MSG_OUT, "libdvdnav: admap not located\n"); return DVDNAV_STATUS_ERR;

1 0

r948 - trunk/libdvdnav/src/searching.c
by nicodvb 14 Jul '07

14 Jul '07

Author: nicodvb Date: Sat Jul 14 13:28:12 2007 New Revision: 948 Log: a beauty mask Modified: trunk/libdvdnav/src/searching.c Modified: trunk/libdvdnav/src/searching.c ============================================================================== --- trunk/libdvdnav/src/searching.c (original) +++ trunk/libdvdnav/src/searching.c Sat Jul 14 13:28:12 2007 @@ -88,16 +88,13 @@ static dvdnav_status_t dvdnav_scan_admap /* fprintf(MSG_OUT, "libdvdnav: Found block %u\n", next_vobu); */ - if(vobu_start <= seekto_block && - next_vobu > seekto_block) { + if(vobu_start <= seekto_block && next_vobu > seekto_block) break; - } else { - vobu_start = next_vobu; - } - address ++; + vobu_start = next_vobu; + address++; } - *vobu = vobu_start; - return DVDNAV_STATUS_OK; + *vobu = vobu_start; + return DVDNAV_STATUS_OK; } fprintf(MSG_OUT, "libdvdnav: admap not located\n"); return DVDNAV_STATUS_ERR;

1 0

r947 - trunk/libdvdnav/src/searching.c
by nicodvb 14 Jul '07

14 Jul '07

Author: nicodvb Date: Sat Jul 14 13:25:44 2007 New Revision: 947 Log: make dvdnav_sector_search() work correctly for blocks in the last vobu; patch by ggurov+abc-bg Modified: trunk/libdvdnav/src/searching.c Modified: trunk/libdvdnav/src/searching.c ============================================================================== --- trunk/libdvdnav/src/searching.c (original) +++ trunk/libdvdnav/src/searching.c Sat Jul 14 13:25:44 2007 @@ -78,32 +78,26 @@ static dvdnav_status_t dvdnav_scan_admap if(admap) { uint32_t address = 0; uint32_t vobu_start, next_vobu; - int32_t found = 0; int admap_entries = (admap->last_byte + 1 - VOBU_ADMAP_SIZE)/VOBU_ADMAP_SIZE; /* Search through ADMAP for best sector */ vobu_start = SRI_END_OF_CELL; /* FIXME: Implement a faster search algorithm */ - while((!found) && (address < admap_entries)) { + while(address < admap_entries) { next_vobu = admap->vobu_start_sectors[address]; /* fprintf(MSG_OUT, "libdvdnav: Found block %u\n", next_vobu); */ if(vobu_start <= seekto_block && next_vobu > seekto_block) { - found = 1; + break; } else { vobu_start = next_vobu; } address ++; } - if(found) { *vobu = vobu_start; return DVDNAV_STATUS_OK; - } else { - fprintf(MSG_OUT, "libdvdnav: Could not locate block\n"); - return DVDNAV_STATUS_ERR; - } } fprintf(MSG_OUT, "libdvdnav: admap not located\n"); return DVDNAV_STATUS_ERR;

1 0