[rtmpdump] branch master updated. ee5456b Update OpenSSL support

[Howard Chu]

Dominik 'Rathann' Mierzejewski wrote:
> On Friday, 01 March 2024 at 16:01, Howard Chu wrote:
>> Dominik 'Rathann' Mierzejewski wrote:
>>> Hello, Howard.
>>> Unfortunately, this breaks building with GnuTLS, e.g.:
>>
>> Thanks for that. I suspected there'd be a problem here but didn't have
>> time to check it myself.
> 
> You're welcome. Coincidentally, I've decided to submit rtmpdump to
> Fedora. It's been part of RPM Fusion for quite long for legal reasons,
> but Red Hat legal cleared it for inclusion some time ago. I'm glad to
> see activity upstream.
> 
> On a side note, I'm told the OBS Studio fork of librtmp has some nice
> improvements over the original code:
> https://github.com/obsproject/obs-studio/tree/master/plugins/obs-outputs/librtmp
> It might be worth taking a look. If you merged their improvements,
> perhaps they can be convinced to stop bundling librtmp.

>From what I can see, they've deleted some essential features:

https://github.com/obsproject/obs-studio/commit/7d07b57993cdd8114afca6df2c4eecc619264447
  "Remove encrypted RTMP support"

https://github.com/obsproject/obs-studio/commit/2f4447a7a154b62e5a6e07733eaddd83b9226c45
  "Remove server support from librtmp"

That doesn't sound like they'd be particularly interested in using the original library.

Granted, we may eventually have to remove RTMPE support ourselves as well, or be
forced to bundle our own copy of RC4 since most modern crypto libraries are dropping
it. But for now it looks like their goals are not aligned with ours.