[rtmpdump] [PATCH] Extended timestamp field may be present in type 3 chunk headers

[Martin Storsjö]

On Mon, 3 Mar 2014, Martin Panter wrote:

> On 2 March 2014 18:26, Martin Storsjö <martin at martin.st> wrote:
>
>> I'd like to make sure this is fixed in the libavformat rtmp implementation
>> as well, but it's pretty hard to do so without a stream to test. Or are you
>> able to implement it for libavformat as well?
>
> Looks like the relevant function may be rtmp_packet_read_one_chunk()
> in libavformat/rtmppkt.c. When I get a chance I’ll see if I can
> reproduce the problem and test it, though I’m curious why FF MPEG and
> “libav” both have the different internal and external RTMP
> implementations. I assume you have to use different build or run time
> options to exercise the internal code. (My “ffmpeg” command currently
> shows “--enable-librtmp”, and I got MPV playing RTMP properly without
> this timestamp issue by getting it to use a modified librtmp.1.so
> without changing the FF MPGE libraries.)

Yes, to use the internal code, just omit --enable-librtmp. Originally the 
internal implementation was less featureful, but at the moment it should 
be pretty much on par with librtmp, and it's quite useful to be able to 
test with the other implementation when looking into bugs in either of 
them.

// Martin