[rtmpdump] [PATCH] Better URL decoding support

[Steven Penny]

On Tue, Oct 23, 2012 at 11:39 PM, NhJm wrote:
>> -               /* skip extension */
>> -               if (subExt && p == ext) {
>> -                       p += 4;
>> -                       pplen -= 4;
>> -                       continue;
>> -               }
>
> Please be careful not to break things.

If you are certain this is an error, please state as such. In the mean time I
will assume it is and check it.

> Anyways, the proper behavior is to actually *NOT* do any urldecoding. The
> %xx should be sent to the server as-is.

This has not been my experience. Admittedly I have only been testing with that
one server, but it is not accepting encoded characters. Notice carefully the
literal newlines in the first example.

WORKS

$ rtmpdump -o a.flv -r rtmp://freeview.fms.visionip.tv/live/tvnetwork-hellenict
v-sigma-hsslive-25f-4x3-SDh%0a -B 1 -V
DEBUG: Hostname : freeview.fms.visionip.tv
DEBUG: Port     : 1935
DEBUG: Playpath : tvnetwork-hellenictv-sigma-hsslive-25f-4x3-SDh

DEBUG: tcUrl    : rtmp://freeview.fms.visionip.tv:1935/live
DEBUG: app      : live
...
DEBUG: Property: <Name:            details, STRING:     tvnetwork-hellenictv-sig
ma-hsslive-25f-4x3-SDh
>
DEBUG: (object end)
DEBUG: (object end)
DEBUG: HandleInvoke, server invoking <onStatus>
DEBUG: HandleInvoke, onStatus: NetStream.Play.Stop
DEBUG: Invoking deleteStream
DEBUG: Got Play.Complete or Play.Stop from server. Assuming stream is complete
46.088 kB / 1.63 sec
DEBUG: RTMP_Read returned: 0
Download complete
DEBUG: Closing connection.


NOT WORK

$ rtmpdump -o a.flv -r rtmp://freeview.fms.visionip.tv/live -y tvnetwork-hellen
ictv-sigma-hsslive-25f-4x3-SDh%0a -B 1 -V
DEBUG: Hostname : freeview.fms.visionip.tv
DEBUG: Port     : 1935
DEBUG: Playpath : tvnetwork-hellenictv-sigma-hsslive-25f-4x3-SDh%0a
DEBUG: tcUrl    : rtmp://freeview.fms.visionip.tv:1935/live
DEBUG: app      : live
...
DEBUG: Property: <Name:        description, STRING:     rtmp://rtmp-origin-01.fm
s.visionip.tv:1935/rtmpinput1/_definst_/tvnetwork-hellenictv-sigma-hsslive-25f-4
x3-SDh%0a|rtmp://rtmp-origin-02.fms.visionip.tv:1935/rtmpinput1/_definst_/tvnetw
ork-hellenictv-sigma-hsslive-25f-4x3-SDh%0a is now unpublished>
DEBUG: Property: <Name:           clientid, NUMBER:     860643237.00>
DEBUG: (object end)
DEBUG: (object end)
DEBUG: HandleInvoke, server invoking <onStatus>
DEBUG: HandleInvoke, onStatus: NetStream.Play.UnpublishNotify
DEBUG: Invoking deleteStream
DEBUG: Closing connection.