[rtmpdump] [PATCH] Add quotes to -o value

[NhJm]

Never said that -o wasn't worthy of quotation. Just saying that the problem
(with the way *all* of the parameters are created) is that they're not
properly being escaped. Sending a double quote to the server in *any* of
the connect/play parameters will cause issues (such as the ability to
execute arbitrary commands).
On May 20, 2012 9:41 PM, "Steven Penny" <svnpenn at gmail.com> wrote:

> NhJm wrote:
> > "not sufficient" does not mean "not needed".
> >
> > Removing quotes (without properly escaping things) would just break
> anything
> > that currently contains spaces (such as the flashVer).
>
> Your reasoning is non sensical.
>
> Either all the parameters should have quotes, or none of them.
>
> Otherwise I am curious as to why
>
> -r
> -a
> -f
> -W
> -p
> -j
> -y
>
> are worthy of quotes, and -o is not?
> _______________________________________________
> rtmpdump mailing list
> rtmpdump at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/rtmpdump
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mplayerhq.hu/pipermail/rtmpdump/attachments/20120520/b2429312/attachment.html>