[rtmpdump] [PATCH] rtmpdump is linked with system librtmp.a if it exists

Howard Chu hyc at highlandsun.com
Fri Mar 9 22:01:15 CET 2012


Itay Perl wrote:
> Hello,
>
> It seems that the main Makefile tries to link the rtmpdump executables with the
> system librtmp.a if one is installed, instead of the one inside the source tree.
> This could be a problem when upgrading from an older version.
>
> ---
>   Makefile |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index a1595a8..80782ad 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -35,7 +35,7 @@ MANDIR=$(DESTDIR)$(mandir)
>   LIBS_posix=
>   LIBS_darwin=
>   LIBS_mingw=-lws2_32 -lwinmm -lgdi32
> -LIB_RTMP=-Llibrtmp -lrtmp
> +LIB_RTMP=librtmp/librtmp.a
>   LIBS=$(LIB_RTMP) $(CRYPTO_LIB) $(LIBS_$(SYS)) $(XLIBS)
>
>   THREADLIB_posix=-lpthread

The "-Llibrtmp" will tell the linker to look in the build tree first, so your 
patch is unnecessary. You can override the LIB_RTMP macro on the make 
commandline if you really need to, so your patch is unnecessary.


More information about the rtmpdump mailing list