[rtmpdump] rutube.ru dumping stopped working: ERROR: RTMP_ReadPacket, failed to read RTMP packet header

[KSV]

instead of deleting the line we should fix it. due to lack of brackets around the expression, compiler was interpreting it in the 

wrong way. following patch will fix it.


diff --git librtmp/rtmp.c librtmp/rtmp.c
index 4b17a49..704f0dc 100644
--- librtmp/rtmp.c
+++ librtmp/rtmp.c
@@ -1337,7 +1361,7 @@ ReadN(RTMP *r, char *buffer, int n)
       nBytes = nRead;
       r->m_nBytesIn += nRead;
       if (r->m_bSendCounter
-          && r->m_nBytesIn > r->m_nBytesInSent + r->m_nClientBW / 2)
+          && r->m_nBytesIn > (r->m_nBytesInSent + r->m_nClientBW / 10))
         if (!SendBytesReceived(r))
             return FALSE;
     }

i increased the value to 10 so it will send the bytes received report after each 250 KB block of data is received.
it's useful for slower connections otherwise server may drop connection when bytes received report isn't sent too frequently.


________________________________
From: compn <tempn at twmi.rr.com>
To: rtmpdump at mplayerhq.hu
Sent: Sunday, 6 November 2011 6:14 PM
Subject: Re: [rtmpdump] rutube.ru dumping stopped working: ERROR: RTMP_ReadPacket, failed to read RTMP packet header

On Sun, 06 Nov 2011 04:13:54 -0500, al_9x at yahoo.com wrote:
>On 11/6/2011 1:42 AM, chapun67 wrote:
>> in a directory in the file librtmp rtmp.c, line 1331 (function in 
>> ReadN), delete: r-> m_nBytesInSent eventually got: if (r-> 
>> m_bSendCounter & & r-> m_nBytesIn> r-> m_nClientBW / 2)
>
>Worked, thanks.
>
>Can someone review (and accept) this?

could you submit a patch against git? librtmp/rtmp.c:1331 is different.

-compn
_______________________________________________
rtmpdump mailing list
rtmpdump at mplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/rtmpdump
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mplayerhq.hu/pipermail/rtmpdump/attachments/20111107/6adcbc9f/attachment.html>