[rtmpdump] How to submit a patch

Howard Chu hyc at highlandsun.com
Sat Jul 23 03:14:42 CEST 2011

Казаков Виктор wrote:
> Okay, here it is:
> https://github.com/UncleCJ/rtmpdump-gitmirror/pull/1/files

I don't believe you should be rejecting packets even if they have an "unknown" 
packet type.

This particular patch changes too many things, apparently unrelated to the bug 
you were reporting. Patches should be concise and to the point, with no other 
irrelevant changes.

> 17.05.2011, 00:34, pnixte at gmail.com:
>> Proof-read it, then just send it to the list.

More information about the rtmpdump mailing list