[rtmpdump] [PATCH] expose http client
hyc at highlandsun.com
Tue Feb 9 20:50:14 CET 2010
Antti Ajanki wrote:
> This patch 1) exposes http_get(), 2) makes it callback-based, and 3) adds
> a bit stricter error checking (all status codes outside [200, 299] are
> considered as errors).
This isn't quite right. The expected response to the If-Modified-Since query
is 304 if the target has not been modified. (Of course, the client doesn't
need to do anything further then, but it is not an error.)
And really, if you want to use this function for more general purposes, then
it ought to distinguish between 3xx (request OK, URL not retrieved), 4xx (URL
is invalid), 5xx (server is hosed) and connect failure (server didn't answer).
> Motivation for these changes is that rtmpdump-yle
> needs a simple the http client.
More information about the rtmpdump