[rtmpdump] [PATCH] Make crypto support configurable through make variables

Howard Chu hyc at highlandsun.com
Wed Apr 7 10:22:47 CEST 2010

Martin Storsjö wrote:
> On Wed, 7 Apr 2010, Howard Chu wrote:
>> This patch is still problematic. Removing CRYPTO from rtmp.h makes it
>> impossible for an app using librtmp to determine whether CRYPTO support is
>> present or not.
> Yes, that's true... Is the issue ok with the latest commits you made? Apps
> using the lib still won't know if crypto support is available, but I guess
> the lib simply fails cleanly if it tries to do something that would
> succeed otherwise? I guess this isn't an issue in the cases where the user
> explicitly has chosen not to include support for that.

rtmpdump, rtmpgw, and rtmpsuck need to be rewritten to avoid the question. 
rtmpdump and rtmpgw need to be rewritten to use the new option parser anyway 

Right now I'm faced with the question of how to maintain backward 
compatibility for the command line, without adding a bunch of redundant code. 
(I hate bloat.) The easiest thing of course would be to rip out all of the old 
option handling and drop backward compatibility.

   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/

More information about the rtmpdump mailing list