[rtmpdump] [PATCH] Make crypto support configurable through make variables

Howard Chu hyc at highlandsun.com
Wed Apr 7 09:40:22 CEST 2010

Martin Storsjö wrote:
> On Wed, 7 Apr 2010, Howard Chu wrote:
>> Martin Storsjö wrote:
>>> Hi,
>>> Currently, if one wants to build librtmp without crypto support, one has
>>> to edit rtmp.h to remove the CRYPTO definition and then edit the makefile
>>> to remove the reference to hashswf.o. With the attached patch, a user can
>>> simply do
>>> make CRYPTO=no
>>> to compile without crypto support, without having to edit the checked out
>>> files.
>> You used Gmake-specific syntax in your patch, I've committed a generic
>> solution instead. Just use "make CRYPTO=" to turn off crypto support.
> Thanks, that looks very good!

This patch is still problematic. Removing CRYPTO from rtmp.h makes it 
impossible for an app using librtmp to determine whether CRYPTO support is 
present or not.

   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/

More information about the rtmpdump mailing list