[rtmpdump] Issue with brightcove and auth param

[Antti Ajanki]

Howard Chu wrote:
> Monsieur Video wrote:
>> Hi,
>>
>> There seems to be an issue with Brightcove with rtmpdump 1.9, the
>> following fixes it:
>>
>> --- rtmp.cpp    (revision 52)
>> +++ rtmp.cpp    (working copy)
>> @@ -766,8 +766,8 @@
>>    // add auth string
>>    if(Link.auth)
>>    {
>> -//      *enc = 0x01; enc++;
>> -//      *enc = 0x01; enc++;
>> +      *enc = 0x01; enc++;
>> +      *enc = 0x01; enc++;
>>  
>>        enc += EncodeString(enc, Link.auth);
>>    }
>>
>> Any idea why that was commented out to start with? (seems to be right
>> back in r12)
> 
> It was commented out because it was commented out in the rtmpdump-YLE code I
> was merging. I dunno, seems like it's safe to leave it in since the 1.6 code
> was working fine with it before.

In rtmpdump-yle it has to be commented out because YLE servers do not
work otherwise.

If I understand correctly, these values are AMF-encoded parameters to
the server-side OnConnect handler. Apparently, Brightcove server expects
that the first parameter is of type Boolean (the first 0x01) and has
value true (the second 0x01) whereas the YLE server expect that the
first parameter is a certain string (given in Link.auth). Because we
don't have any control over what kind of parameters the server-side
function takes, I don't think that it is possible to have one default
value that would work on all servers.

Antti