[NUT-devel] [nut]: r568 - src/trunk/Makefile

[Rich Felker]

On Sun, Feb 03, 2008 at 06:02:36PM +0100, Diego Biurrun wrote:
> On Sat, Feb 02, 2008 at 02:12:40PM -0500, Rich Felker wrote:
> > On Sat, Feb 02, 2008 at 02:56:46PM +0100, diego wrote:
> > > 
> > > Log:
> > > Install shared library as well.
> > > 
> > > --- src/trunk/Makefile	(original)
> > > +++ src/trunk/Makefile	Sat Feb  2 14:56:45 2008
> > > @@ -27,7 +27,7 @@ install: install-libnut install-nututils
> > >  
> > >  install-libnut: libnut
> > >  	install -d $(prefix)/lib
> > > -	install -m 644 libnut/libnut.a $(prefix)/lib
> > > +	install -m 644 libnut/libnut.a libnut/libnut.so $(prefix)/lib
> > 
> > What about platforms that do not have shared libraries?!?
> 
> Like your handcrafted system?
> 
> Shared libraries are built by default right now, so they should be
> installed by default as well.

Even on OSX building and installing shared libraries is different from
Linux and the free BSDs. Blatant GNUisms do not belong in a hardcoded
build script. Either shared libs should be in a nondefault rule with
instructions on how to build them for the supported systems, or some
sort of configure script should be used to detect whether/how to build
them for the target system.

Rich