[NUT-devel] Suggestions [PATCH]

[Michael Niedermayer]

Hi

On Wed, Mar 01, 2006 at 08:59:31AM -0500, Rich Felker wrote:
[...]
> > > >      EOR frames MUST be zero-length and must be set keyframe.
> > > >      All streams SHOULD end with EOR, where the pts of the EOR indicates the
> > > >      end presentation time of the final frame.
> > > >      An EOR set stream is unset by the first content frames.
> > > >      EOR can only be unset in streams with zero decode_delay .
> > > > +    has_checksum must be set if the frame is larger then 64kb or its
> > > 
> > > 2*max_distance ?
> > 
> > ok
> 
> Why is it 2* ? Why not just max_distance?

the syncpoint distance is a tradeoff between resync ability after ANY error
and overhead

the value here is a tradeoff between detecting rare damaged framesize and
overhead
so it makes sense to have this larger, and why not yet another variable,
well if we cant decide what value is good how should a poor muxer?


[...]
> > > >  checksum
> > > >      crc32 checksum
> > > >      checksum is calculated for the area pointed to by forward_ptr not
> > > >      including the checksum itself (from first byte after the
> > > >      forward_ptr until last byte before the checksum).
> > > 
> > > You should probably mention what area the checksum of frame headers 
> > > cover...
> > 
> > ok
> 
> Is a checksum of 1 byte really useful? 

yes

[...]
-- 
Michael