[NUT-devel] Patch for info frames

[Michael Niedermayer]

Hi

On Sun, Feb 26, 2006 at 09:19:22AM +0200, Oded Shimon wrote:
[...]
> > > > Index: DOCS/tech/mpcf.txt
> > > > ===================================================================
> > > > RCS file: /cvsroot/mplayer/main/DOCS/tech/mpcf.txt,v
> > > > retrieving revision 1.113
> > > > diff -u -r1.113 mpcf.txt
> > > > --- DOCS/tech/mpcf.txt	25 Feb 2006 18:51:46 -0000	1.113
> > > > +++ DOCS/tech/mpcf.txt	25 Feb 2006 19:41:12 -0000
> > > > @@ -640,6 +640,9 @@
> > > >  
> > > >  chapter_len
> > > >      Length of chapter in same timebase of chapter_start.
> > > > +    In info streams, if chapter_len is zero, chapter_len is the pts of
> > > > +    the first EOR or info frame with a different chapter_id in the same
> > > > +    info stream, minus chapter_start.
> > > 
> > > i would suggest (though i am not strongly against the above):
> > > In info streams, chapter_len may be zero for some but not all info frames
> > > of a chapter if the length is not known yet
> > > this is simpler to remux with filling in length everywhere and its more
> > > error robust
> > 
> > I discussed the idea of storing length in the final info frame of the
> > span with Oded, but we agreed it was a bad idea because it would mean
> > you would have to mux an extra 'duplicate' right at the end of the
> > span, exactly at the moment where it ceased to be relevant. This seems
> > totally wasteful and counter-intuitive.
> > 
> > Also I don't like the idea of the frames not being binary-identical.
> > As long as they're binary-identical, the player can ignore the
> > contents of duplicate frames completely, which simplifies the logic.
> 
> Agree here too.

and what about the timebase? the info stream timbase cannot be every timebase,
it cant be their lcm either as that would overflow the max num/den sizes

and after you solved that, what about remuxing from info frames to packets
everyone except rich will use msec based info streams which will have
msec based chapter ends which you probably wont be able to specify in
any other stream timebase ... do we need to keep the dummy info streams or
just round the timestamps (yeah everyone WILL round them)

[...]
-- 
Michael