[mplayerosx-devel] Merging OSX Extended

[Guillaume POIRIER]

Hello,

On Mon, May 11, 2009 at 10:53 PM, Adrian Stutz <adrian at sttz.ch> wrote:
> On Sat, May 9, 2009 at 12:19 PM, Guillaume POIRIER <poirierg at gmail.com> wrote:
>> MPlayer and FFmpeg developement rules require to commit changes in a
>> way that makes them as much readable and reviewable as possible.
>>
>> So big changes are frown upon.
>>
>> However, MPlayerOSX has been a one-man project so far (Nicolas
>> Plourde), and I'm not sure what rule he followed so far. It may be a
>> good idea to drop him a mail to has his that.
>
> I did write him some time ago and he told me I could go ahead with the
> merge, though we didn't discuss any specifics.

I put him in CC in case he wants to take part to the discussion.


> I do know the MPlayer rules and that's mostly why I want to discuss it
> here first. I've been steadily increasing the organization of the
> development, separating changes, tracking bugs or gathering feedback.
> I hope to continue this as part of the official MPlayer OSX project
> and to hopefully improve quality with more people looking at my
> changes.

Hopefully yes, but I don't think there are that may people who have
much knowledge about OSX's API! :-(


> Though going back and breaking down all changes would be a huge effort
> and IMO not worth the time, which can be invested into advancing
> development instead.

I know the feeling. I know that if the rules of development are too
tough, they scare people away, and people end-up working on their own
fork... which is a terrible waste of time!

Please consider this:
Pulling small, self-contained changes from your fork may be a chance
to "proofread" your own code, giving your a chance to improve the
overall quality of the code that you pull....

I don't know how much code/work you've put towards your fork, but this
"merging" method may be worthwhile after all....


> I can imagine doing either:
> * Merging Extended in one go, just like an initial import.

Certainly not.


> * Merging all ten revisions individually

If each of these revisions make sense individually, that the solution
I dislike the least.


> * Moving the Extended repo and disuse the current one

Well, you can hardly call that merging OSX Extended, can you? (which
is the title of the mailing list thread!)


In the end, I'm not the one making decisions, I'm just trying to help
you conform to how things are done on MPlayer and FFmpeg projects.
I'm happier if you ignore my advices and work heavily on MPlayerOSX to
make it a lot better than having you run away because of the rules are
too hard to work with.

But I'd be much happier if you could do "small enough" incremental
changes instead! :-)


>> Did you try using the contact page of sourceforge?
>
> I did try to find any info on the sourceforge page but wanted to ask
> here first before I contact them directly.

IFAIR, the people from this project have never been part of MPlayer's
dev team, and Nico took over maintainer ship on mplayer's svn...

Cheers!

Guillaume

--
Only a very small fraction of our DNA does anything; the rest is all
comments and ifdefs.

Don Marquis  - "Procrastination is the art of keeping up with
yesterday." - http://www.brainyquote.com/quotes/authors/d/don_marquis.html