[MPlayer-users] Release 1.1 first packaging attempt

[Reimar Döffinger]

On Fri, May 18, 2012 at 06:19:45PM +0200, Raimund Steger wrote:
> 
> On Fri, May 18, 2012 16:21, Reimar Döffinger wrote:
> > On Fri, May 18, 2012 at 03:50:47PM +0200, Raimund Steger wrote:
> >> > I presume the ldflags are only necessary to get X11 support, it
> >> > will compile without?
> >> > And in that case, shouldn't --extra-ldflags="-lrt" work just as well?
> >>
> >> I've found that the additional '-lX11' is necessary to compile the gl vo
> >> if the x11 vo isn't enabled. This configuration is the default (without
> >> any special configure arguments) on my Solaris 10 machines.
> >
> > Hm, I believe what should happen in that case is that the gl vo is
> > compiled against SDL only?
> > But in that case -lX11 should not be necessary.
> > Can you give some more details on what goes wrong with OpenGL in that
> > case?
> 
> Interestingly, ./configure does seem to enable x11 *and* sdl backends for
> gl even if x11 was not found to work. This probably means that the OpenGL
> test works individually and doesn't hit the problematic Xutil.h or
> XShmGetEventBase code paths.
> 
> An excerpt from the ./configure output (full output at the end of the mail):
> 
> [...]
> Checking for X11 headers presence ... yes (using /usr/openwin/include)
> Checking for X11 ... no (check if the dev(el) packages are installed)
> [...]
> Checking for SDL ... yes (using sdl-config)
> Checking for OpenGL ... yes (backends: x11 sdl)

I think I fixed it to not try to use X11 when it was not detected.
That also disrespected --disable-x11 before...
Testing welcome.

> >> (1) use 'statement_check_broken X11/Xlib.h'... instead of
> >>     'statement_check'... in ./configure, line 4270 (in the
> >>     version from the 1.1 tarball)
> >
> > Curious, but should not be an issue to change.
> 
> The appropriate #include seems to have been merged into XFree86 long ago:
> http://cvsweb.xfree86.org/cvsweb/xc/lib/X11/Xutil.h.diff?r1=3.2&r2=3.3
> 
> 
> >> (2) add a declaration like:
> >>
> >>     extern Status XShmGetEventBase(Display *display);
> >>
> >>     to libvo/vo_x11.c, around l. 42.
> >
> > There no X header that provides that function declaration?
> > Seems strange to have it in the libs but not in any header...
> 
> This seems to have been a problem in older XFree86 as well, I've found the
> following old Debian bug:

Hm, maybe it is best to leave these parts as-is, it should mean that
it's at least possible to compile MPlayer on such a system, it
"just" will be without X11 support.

> > [...]
> > Could you test the attached patch?
> 
> Works for me -- thanks!

Great, committed.