[MPlayer-users] Unable to Compile Mplayer Revision 34652

[Reimar Döffinger]

On Wed, Feb 15, 2012 at 12:56:16AM +0400, Vladimir Mosgalin wrote:
> Or I could make more complex patch which adds configure option for
> simple hardening (like this) without performance impact, probably
> enabled by default, and configure option for stronger hardening with
> possibly slight performance impact (with stack protection activated). Do
> you think something like that will be accepted?

Depends on how ugly it is and how much benchmarking you're willing
to do I guess :-).
For example I think that at least on x86_64 we should be compiling
with -fPIE and link with -fPIE -pie by default, however I've never
had the time and motivation to properly test it.
On 32 bit x86 I think it shouldn't be necessary to compile with
-fPIE in order to be able to link with -pie, so we should add
that by default, too.
IMHO both of these have a far higher impact on security than all
the other options (well, stack protector might come close, but
heap exploits have gotten too "easy" nowadays).