[MPlayer-users] mplayer crash playing .mkv with embedded vobsub subtitles

[Reimar Döffinger]

On Mon, May 31, 2010 at 10:25:58PM +0300, Risto Pajula wrote:
> 2010/5/31, Reimar Döffinger <Reimar.Doeffinger at gmx.de>:
> > On Mon, May 31, 2010 at 08:46:25PM +0300, Risto Pajula wrote:
> >> Any help would be appreciated. I'm also willing to debug the problem
> >> further if you could give any pointers where to look.
> >
> > Well, (part of) the file would be most useful for fixing.
> 
> I have uploaded first 40MB of the file to the
> ftp://upload.mplayerhq.hu/MPlayer/incoming/
> name of the file vobsub_crash.mkv.

Thanks for the sample.

> > Otherwise I expect that e.g. -vo gl would avoid the issue.
> 
> You are right that this avoids the crash... However no subtitles are displayed.

Actually they are... Just nowhere you'd normally see them.
If you fiddled with -panscanrange and zoomed out a lot you should
suddenly see them appear.
Anyway, fixed.

> > Something like this (completely untested) patch might help,
> > though I expect it will still display wrong:
> > Index: vo_xv.c
> > +    h = FFMIN(h, image_height - h0);
> 
> This did not compile. I tried with:
>     h = FFMIN(h, image_height - y0);
> 
> Crash was avoided but no subtitles displayed...

Also fixed, in a way that alone would make the subtitles
appear as well, though they would be cut-off and thus unreadable
still...