[MPlayer-users] On a NSLU2 the $(AS) -DHAVE_AV_CONFIG_H etc line fails

[Reimar Döffinger]

On Tue, Jun 02, 2009 at 08:13:01PM +0200, old.codger at mac.com wrote:
> Reimar thanks for your advice.
>
> Here's the problem I get with $(AS) in common.mak
>
> cc -DHAVE_AV_CONFIG_H -I.. -I.. -Wundef -Wdisabled-optimization -Wno- 
> pointer-sign -Wdeclaration-after-statement -std=gnu99 -Wall -Wno-switch 
> -Wpointer-arith -Wredundant-decls -O4  -mcpu=xscale -pipe -ffast-math 
> -fomit-frame-pointer -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I.    -c 
> -o arm/dsputil_arm.o arm/dsputil_arm.c
> In file included from arm/dsputil_arm.c:22:
> ../libavcodec/dsputil.h:637:5: warning: "HAVE_NEON" is not defined
> arm/dsputil_arm.c:23:5: warning: "HAVE_IPP" is not defined

Note that you should probably update configure to set these to 1
if any of these is available on your device, it should speed up
some things greatly.

> as -DHAVE_AV_CONFIG_H -I.. -I.. -Wundef -Wdisabled-optimization -Wno- 
> pointer-sign -Wdeclaration-after-statement -std=gnu99 -Wall -Wno-switch 
> -Wpointer-arith -Wredundant-decls -O4  -mcpu=xscale -pipe -ffast-math 
> -fomit-frame-pointer -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I.    -c 
> -o arm/dsputil_arm_s.o arm/dsputil_arm_s.S
> as: unrecognized option '-HAVE_AV_CONFIG_H'
> make[2]: *** [arm/dsputil_arm_s.o] Error 1
> make[2]: Leaving directory `/usr/src/mplayer/mplayer/libavcodec'
> make[1]: *** [libavcodec/libavcodec.a] Error 2
> make[1]: Leaving directory `/usr/src/mplayer/mplayer'
> make: *** [configure-stamp] Error 2
>
> A change to commom.mak $(AS)  to $(CC)

It's the wrong solution to the problem though.
$(AS) should not be "as", and I don't know where that definition
comes from in your case, MPlayer's configure does not set it.
I changed it to set AS to the C compiler, which is the correct way,
so it should work now (unless you added a hack somewhere that sets
AS to the wrong value).
Note: I know the variable name "AS" for something that may not be
set to "as" sucks, I suggested it to be changed in the FFmpeg
but nothing came of that.