[MPlayer-users] "'HAVE_LOG2' is not defined" make error in latest SVN

[Ilja Sekler]

On 11.07.2009 01:36, Richard Bromley wrote:

> While compiling MPlayer SVN 29416, I get these errors:
> 
> In file included from libmpcodecs/vf_fspp.c:50:
> ./libavutil/internal.h:268:6: warning: "HAVE_LOG2" is not defined
> In file included from libmpcodecs/vf_fspp.c:51:
> ./libavutil/internal.h:269: error: static declaration of 'log2'
> follows non-static declaration
> make: *** [libmpcodecs/vf_fspp.o] Error 1
> 
> 
> Last week, an earlier SVN revision of MPlayer compiled without
> errors on the same machine (a Gentoo Linux system).

I get the same build error on Ubuntu 9.04, the culprit could be:

svn log -vl 1 libavutil/internal.h
------------------------------------------------------------------------
r19395 | alexc | 2009-07-10 21:20:06 +0200 (Fr, 10. Jul 2009) | 3 lines
Geänderte Pfade:
   M /trunk/configure
   M /trunk/libavutil/internal.h

Add a log2 replacement for systems that haven't quite caught up with the C99
standard library.


svn diff -c 19395 libavutil/
Index: libavutil/internal.h
===================================================================
--- libavutil/internal.h	(Revision 19394)
+++ libavutil/internal.h	(Revision 19395)
@@ -265,6 +265,13 @@
 }
 #endif /* HAVE_LLRINT */

+#if !HAVE_LOG2
+static av_always_inline av_const double log2(double x)
+{
+    return log(x) * 1.44269504088896340736;
+}
+#endif /* HAVE_LOG2 */
+
 #if !HAVE_LRINT
 static av_always_inline av_const long int lrint(double x)
 {