[MPlayer-users] chapter list bug

Nico Sabbi nicola_sabbi at fastwebnet.it
Sat May 26 21:59:15 CEST 2007

Jared Breland wrote:
> I took a stab at fixing this, and as far as I can tell I was correct about
> the off-by-one error.  In stream_dvd.c, line 617:
> for(i=0; i<pgc->nr_of_programs-1; i++)
> That will effectively stop the loop at 2 elements prior to the end.  I'm
> pretty sure you'd want to stop it at only one element from the end.  Either
> of these would work:
> for(i=0; i<pgc->nr_of_programs; i++)
> for(i=0; i<=pgc->nr_of_programs-1; i++)
> I'm attaching a patch that fixed the issue, at least on my system.  I'd
> greatly appreciate any feedback concerning confirmation of the issue or
> acceptance of the patch.  I'm writing a DVD audio ripping script right now
> that relies on mplayer, and I need to know whether this will be fixed before
> I release it.  :-)
> Oh, and I realize that the MPlayer version info I provided below isn't very
> helpful.  I appear to be using the CVS version from 03/21/2007, based on
> filename of the archive.  This is the current stable package for amd64
> provided by Gentoo.
> Thanks again.

wrong patch; I'll fix it differently. Please, don't top post

More information about the MPlayer-users mailing list