[MPlayer-users] Bug: SIGSEGV while trying to play .ogg

[Nico Sabbi]

Sebastian Krämer wrote:

>>
>>No idea what (i.e. which patch) caused this, but it should be fixed.
>>    
>>
>
>I know who wrote the line you fixed now. But strangely, it is quite old:
>
>$ svn blame libmpdemux/demux_ogg.c|grep -C 5 ">context)->vi.rate"
> 11576       mosu   if(demuxer->video->id >= 0) {
> 11576       mosu     os = &ogg_d->subs[demuxer->video->id];
> 11576       mosu     rate = os->samplerate;
> 11576       mosu   } else {
> 11576       mosu     os = &ogg_d->subs[demuxer->audio->id];
> 11576       mosu     rate =
>(float)((ov_struct_t*)((sh_audio_t*)demuxer->audio->sh)->context)->vi.rate;
> 11576       mosu   }
> 11576       mosu
> 11576       mosu
> 11576       mosu     switch(cmd) {
> 11576       mosu       case DEMUXER_CTRL_GET_TIME_LENGTH:
>
>(this was on r18739 of course)
>
>$ svn log -r 11576
>------------------------------------------------------------------------
>r11576 | mosu | 2003-12-08 10:47:15 +0100 (Mon, 08 Dec 2003) | 2 lines
>
>Get the total length for Ogg files. Patch by Michael Behrisch
><behrisch at informatik.hu-berlin.de>.
>
>(also see: svn diff -r 11468:11576 libmpdemux/demux_ogg.c)
>
>Maybe something else in that context broke it (not being able to play
>ogg files couldn't hide for more than 2 years?!). But I thought you
>might be interested in that info..
>
>Sebastian
>
>PS: I just checked on the pre8 branch and it plays the file fine..
>  
>

in all cases the whole "context" stuff in demux_ogg is completely broken:
a demuxer should _never ever_ access the decoder's context