[MPlayer-users] Re: Bug when reading dumped .rm files

[Hernan Badino]

Hi,
>
> On Monday 17 July 2006 15:43, Hernan Badino wrote:
>> The same happens if the file is played directly from the rtsp server, 
>> i.e.,
>>
>> mplayer rtsp://ms.espectador.com/audio/app_metafiles/dol0501241.rm
>>
>> has the same behavior as the previously reported. So I think is a
>> problem in the player and not because of a corrupt .rm file.
>
> I can confirm it's a regression introduced in 17150 in ad_realaud.c
>
> http://svn.mplayerhq.hu/mplayer/trunk/libmpcodecs/ad_realaud.c?r1=17013&r2=17150
>
> The eof-checking code was removed so the codec ignore the eof and 
> decode the
> same part again and again.
>
Hello,

You are right. Have you corrected the error? If so, could you please 
check it? I have corrected the error by adding the EOF check after the 
if line in the decode_audio function (line 411 approx.) of 
ad_realdaud.c, i.e.,

411  if(sh->a_in_buffer_len<=0){
-> 412    if (sh->ds->eof) return 0;     
413
414      // fill the buffer!
415      demux_read_data(sh->ds, sh->a_in_buffer, sh->wf->nBlockAlign);
416      sh->a_in_buffer_size=
417      sh->a_in_buffer_len=sh->wf->nBlockAlign;
418  }

I'm not a developer so I can not just check in the changes.

Thanks for the help.

Hernan B.