[MPlayer-users] OSD problems with DVDs

[Dominik 'Rathann' Mierzejewski]

On Thursday, 19 January 2006 at 09:58, Davide Capodaglio wrote:
> Dominik 'Rathann' Mierzejewski ha scritto:
> >On Wednesday, 18 January 2006 at 23:17, Davide Capodaglio wrote:
> >>Hi everybody, these are the problems I have with DVDs and OSD:
> >>
> >>- sometimes the total time is lower than real time, for all the film 
> >>length
> >>- sometimes the total time is lower than real time, but at a certain 
> >>point of the film it becomes the correct time
> >>- sometimes the current time at a certain point goes back to 0: e.g. 
> >>00:00-31:00, then resets to 00:00, then 00:00-28:32, reset to 00:00, etc. 
> >>(VOB boundary??).
> >>(For this I produced a patch, and now the current time follow the total 
> >>time, but if this is wrong I'm stuck again)
> >>- the strangest case: the total time is 00:00, but the current time goes 
> >>on
> >>
> >>All these DVDs with problems work perfectly under xine and even with a 
> >>simple lsdvd.
> >>Can anyone report these problems as well?
> >
> >This is all normal, as MPlayer shows the REAL pts, as decoded from the
> >video stream. MPEG pts don't have to be monotonic AFAIK.
> 
> Well it may be normal for mplayer, but in fact it's an annoying bug, not 
> present for example in xine.
> 
> >>Little OT: If someone is interested I wrote a patch to show CPU usage, 
> >>frames dropped etc (the last part of the status line) as OSD level 4.
> >
> >Please post the patch.
> >
> 
> Attached osd4.patch (it's against mplayer 1.0-pre7try2).
> Any feedback is appreciated.
> 
> >Regards,
> >R.
> >
> 
> Bye
> Davide

> --- mplayer.c.orig	2005-04-15 14:14:24.000000000 +0200
> +++ mplayer.c	2005-12-13 09:21:17.171875000 +0100
> @@ -222,7 +222,8 @@
>  int enqueue=0;
>  #endif
>  
> -#define MAX_OSD_LEVEL 3
> +//DAVIDE
> +#define MAX_OSD_LEVEL 4

Please do not comment your additions like this. It's unnecessary and makes
the code unreadable. Imagine what would happen if every one of many
MPlayer contributors did this. You will be given proper credit at least
in CVS logs.

Please resend without these comments.

Regards,
R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"