[MPlayer-users] [PATCH] make cache2.c readable

[Andrew Savchenko]

> Are -> and > in different color in your editor?

Yep. I've changed it's syntax description, it's easy enough.

> What if my ssh client does not support colors?

Change your ssh client. Moreover you can _mount_ ssh and use any client 
you want.

> I looked at the existing code and tried to figure out
> what style is used there, then apply it over entire file.
>
> I did add spaces around <, >, >= etc because I thought that
>
> if(space>s->buffer_size-pos) space=s->buffer_size-pos;
>
> is *hard to read*. Why should reader waste his time trying to find >
> there? We should encourage, not preclude peer review.
> IOCCC is there ------> http://www.ioccc.org/

Well, I don't stay on that original code is an example for all coders, 
but please understand that a lot variety of programmers has a lot 
variety of preferences, so left those code "as is". It would be a mess 
if anyone'll cosmetically change code of another person.

I can suggest you two solutions of this problem:

1) Format original source as you want, write your own code and apply 
diff -uwbBE to all your changes, then fix diff file by hand.

2) Format original source as you want, create patch to original code, 
write your own code, then apply reverse diff to your code to discard 
cosmetic changes and apply final diff to original code.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-users/attachments/20060824/d3420257/attachment.pgp>