[MPlayer-users] probably my usual stupid question of the week

[D Richard Felker III]

On Fri, Apr 16, 2004 at 12:00:06AM -0700, rcooley wrote:
> On Fri, 16 Apr 2004 01:29:36 -0400
> D Richard Felker III <dalias at aerifal.cx> wrote:
> 
> > There are tricks to get mencoder to compute them
> > for you, but it won't align them at multiple-of-16 boundaries so
> > you're best to just figure out the right size yourself. 
> 
> Attached is a small, simple patch to modify cropdetect to round down to
> the nearest multiple of 16.  Not really made to be comitted, just
> something that makes my life easier (I'd rather do the math in C than in
> my shell scripts that invoke mplayer).

The code seems to be incorrect. It rounds to a larger region, leaving
black border, which makes cropping pointless. You'd need to round the
other direction for it to work. But even this is nonsense, since you
should just scale after cropping rather than overcropping or
undercropping to meet n%16==0 requirements.

Rich