[MPlayer-users] Re: MPlayer 0.90RC2 and cvs - VIDIX bug with RADEON QW

[Christophe BADINA]

> This change causes the dreaded pink screen to return for me. I'm using a
> Sapphire Radeon 7500 which also has the QW chipset and 64 Mb of DDR. I
> guess all these oem boards must have slightly different configurations or
> something?

I've sent patches that work only for MPlayer 0.90RC2 and cvs (3 january), not 
for RC1... Now, cvs version work for me without any modification. 

MPlayer flicker pink only when I resize or move window or toggle 
window/fullscreen mode. MPlayer call radeon_vid_stop_video() before resizing 
or moving window. 
If I remove this line :
	OUTREG(OV0_SCALE_CNTL, SCALER_SOFT_RESET);
and change this line :
        OUTREG(OV0_KEY_CNTL, GRAPHIC_KEY_FN_NE);
to :
	 OUTREG(OV0_KEY_CNTL, GRAPHIC_KEY_FN_EQ);
MPlayer flicker pink less but SCALER_SOFT_RESET is essential to exit program.
MPlayer should do SCALER_SOFT_RESET only when exit. I don't know how... 
Moreover, MPlayer should check rage_ckey_model to reset OV0_KEY_CNTL :

* Patch 0.90 RC2 (only RC2) :

--- MPlayer-0.90rc2/vidix/drivers/radeon_vid.c  Tue Dec 24 18:40:57 2002
+++ MPlayer-0.90rc2.new/vidix/drivers/radeon_vid.c  Sun Jan  5 19:09:23 2003
@@ -949,7 +949,6 @@
 #ifdef RADEON
   switch(def_cap.device_id)
     {
-    case DEVICE_ATI_RADEON_QW:
     case DEVICE_ATI_RADEON_MOBILITY_M6:
     case DEVICE_ATI_RADEON_MOBILITY_M62:
     case DEVICE_ATI_RADEON_MOBILITY_M63:
@@ -957,6 +956,7 @@
       rage_ckey_model=1;
       is_shift_required=1;
       break;
+    case DEVICE_ATI_RADEON_QW:
     case DEVICE_ATI_RADEON_QD:
     case DEVICE_ATI_RADEON_QE:
     case DEVICE_ATI_RADEON_QF:
@@ -1057,7 +1057,11 @@
     OUTREG(OV0_EXCLUSIVE_HORZ, 0);
     OUTREG(OV0_AUTO_FLIP_CNTL, 0);   /* maybe */
     OUTREG(OV0_FILTER_CNTL, FILTER_HARDCODED_COEF);
+    #ifdef RADEON
+    OUTREG(OV0_KEY_CNTL,rage_ckey_model?GRAPHIC_KEY_FN_NE:GRAPHIC_KEY_FN_EQ);
+    #else
     OUTREG(OV0_KEY_CNTL, GRAPHIC_KEY_FN_NE);
+    #endif
     OUTREG(OV0_TEST, 0);
 }

* Patch cvs (5 january) :

--- MPlayerCVS/main/vidix/drivers/radeon_vid.c  Sun Jan  5 16:30:30 2003
+++ MPlayerCVS/main.new/vidix/drivers/radeon_vid.c  Sun Jan  5 19:19:21 2003
@@ -1069,7 +1069,11 @@
     OUTREG(OV0_EXCLUSIVE_HORZ, 0);
     OUTREG(OV0_AUTO_FLIP_CNTL, 0);   /* maybe */
     OUTREG(OV0_FILTER_CNTL, FILTER_HARDCODED_COEF);
+    #ifdef RADEON
+    OUTREG(OV0_KEY_CNTL,rage_ckey_model?GRAPHIC_KEY_FN_NE:GRAPHIC_KEY_FN_EQ);
+    #else
     OUTREG(OV0_KEY_CNTL, GRAPHIC_KEY_FN_NE);
+    #endif
     OUTREG(OV0_TEST, 0);
 }


> Does colour keying actually work (as in you can hide the video window behind
> another without the video showing through) for anyone with a radeon 7500?

I've no problem when I put a window on the top of mplayer's window. The window 
hide video. I use kdm.

Christophe