[MPlayer-users] MPlayer 0.90RC2 and cvs - VIDIX bug with RADEON QW

[Christophe BADINA]

I have a computer with :
	- Hercules 3D Prophet video card with ATI Radeon QW chipset and 64 Mb video 
memory (DDR),
	- Debian GNU/Linux 3.0 r0,
	- kernel 2.4.20,
	- libc6 2.2.5-6,
	- xserver-xfree86 4.2.1-3 package from testing,
	- gcc 2.95.4-14,
	- ld 2.12.90.0.1,
	- as 2.12.90.0.1.

When I use MPlayer 0.90RC1 (mplayer -vo xvidix ...), I have a little pink bar 
at the right of the video.

When I use MPlayer 0.90RC2 or cvs version (3 January), the entire 
window/screen is pink.

I'd searched changes in radeon_vid.c between these two versions. I've found 
RC1 use GRAPHIC_KEY_FN_EQ flag and RC2 use GRAPHIC_KEY_FN_NE.

I've made a little change in radeon_vid.c :

--- MPlayer-0.90rc2/vidix/drivers/radeon_vid.c  Tue Dec 24 18:40:57 2002
+++ MPlayer-0.90rc2.new/vidix/drivers/radeon_vid.c      Fri Jan  3 22:02:18 
2003
@@ -949,7 +949,6 @@
 #ifdef RADEON
   switch(def_cap.device_id)
     {
-    case DEVICE_ATI_RADEON_QW:
     case DEVICE_ATI_RADEON_MOBILITY_M6:
     case DEVICE_ATI_RADEON_MOBILITY_M62:
     case DEVICE_ATI_RADEON_MOBILITY_M63:
@@ -957,6 +956,7 @@
       rage_ckey_model=1;
       is_shift_required=1;
       break;
+    case DEVICE_ATI_RADEON_QW:
     case DEVICE_ATI_RADEON_QD:
     case DEVICE_ATI_RADEON_QE:
     case DEVICE_ATI_RADEON_QF:

The patch for cvs version :

--- MPlayerCVS/main/vidix/drivers/radeon_vid.c  Wed Dec 25 21:57:11 2002
+++ MPlayerCVS/main.new/vidix/drivers/radeon_vid.c      Fri Jan  3 23:36:10 
2003
@@ -960,13 +960,13 @@
 #ifdef RADEON
   switch(def_cap.device_id)
     {
-    case DEVICE_ATI_RADEON_QW:
     case DEVICE_ATI_RADEON_MOBILITY_M6:
     case DEVICE_ATI_RADEON_MOBILITY_M62:
     case DEVICE_ATI_RADEON_MOBILITY_M63:
     case DEVICE_ATI_RADEON_MOBILITY_M64:
     case DEVICE_ATI_RADEON_9000_IF:
       rage_ckey_model=1;
+    case DEVICE_ATI_RADEON_QW:
     case DEVICE_ATI_RADEON_QD:
     case DEVICE_ATI_RADEON_QE:
     case DEVICE_ATI_RADEON_QF:

It's work well with my graphic card. There is no pink when I play a video. 
MPlayer flicker pink only when I resize window or swich window/fullscreen 
mode. I don't know if it work well with all Radeon QW chipset. 

Thank for your work
and happy new year.

Christophe