[MPlayer-G2-dev] basic g2 vp (video pipeline) code

D Richard Felker III dalias at aerifal.cx
Tue Dec 23 16:50:29 CET 2003


On Tue, Dec 23, 2003 at 11:44:23AM +0100, Sascha Sommer wrote:
> > Hi,
> >
> > > [resent because mphq lost it]
> > >
> > > [cut to keep from digging up an old thread with mostly outdated info]
> > > In-Reply-To: <200311021858.hA2IwT9B025362 at mail.mplayerhq.hu>
> > >
> > > On Sun, Nov 02, 2003 at 07:58:29PM +0100, Arpi wrote:
> > > > > Maybe stride should be negotiated at config-time? That would help
> > > >
> > > > nope, its impossiblee imho in many cases, and adds yet another
> > > > limitation...
> > >
> > > I decided to negotiate stride at config-time anyway. :)))))
> > > So now it's time to address these issues...
> >
> > BAD!
> >
> 
> ;)
> Stride may and does change between mutliple lock/unlocks. At least with
> directx
> when the buffers are in videoram. And imho it should only be treaded valid
> between
> frame_start/frame_done. Of course planes[] may change, too.

If you'd RTFS'd, you'd see that for DIRECT and EXPORT type buffers,
the creator of the buffer is always allowed to select the stride,
except in the case where STRIDE_STATIC restriction is in place. The
negotiated stride will just be used by AUTO buffers, and _should_ be
used by DIRECT buffers whenever possible. Examples of when
STRIDE_STATIC should be used are: libavcodec, vf_fil.

Arpi, do you have concrete objections rather than "BAD!"??

Rich




More information about the MPlayer-G2-dev mailing list