[MPlayer-DOCS] [PATCH] xvfwopts compdata docs
diego at biurrun.de
Fri Mar 2 17:04:12 CET 2007
On Fri, Mar 02, 2007 at 11:00:12AM -0500, Compn wrote:
> On Fri, 02 Mar 2007 10:48:29 +0100,
> Diego Biurrun scribed:
> > On Thu, Mar 01, 2007 at 10:11:23PM -0500, Compn wrote:
> > > it took me a while...
> > While this is a nice comment, it's not a good commit message, please
> > change it to something descriptive instead.
> > > --- encoding-guide.xml (revision 22408)
> > > +++ encoding-guide.xml (working copy)
> > > @@ -4270,13 +4270,51 @@
> > >
> > > +First you must build the <application>vfw2menc</application>
> > > program. it is located in the <filename
> > > class="directory">/TOOLS/</filename> subdirectory of MPlayer source.
> > Please keep lines below 80 characters and capitalize after a period.
> Do you mean 80 characters in the xml or 80 characters in the html?
In the source, i.e. in the XML.
> > > +Below is an example with vp6 codec.
> > with the
> > Benjamin, this is not IRC (notice the spelling ;), you're supposed to
> > use uppercase once in a while. I guess your shift key is all grimy
> > because you don't use it, but now it's time to bite the bullet and
> > clean it ;)
> Its not that I can't use the shift key, its just that I have to stop
> sending patches when I'm tired. Perhapse "Don't send patches to the
> list when you are tired" should be in patches.txt. Also IRC is killing
> my spelling, grammar, and punctuation skills.
I was only pulling your leg, so never mind.
> Thank you for reviewing.
You are welcome.
> I forgot the policy... Do you want me to commit after fixing these
> errors or submit a fixed patch in the future?
I'm fine with direct commits. The stuff in SVN will get reviewed
More information about the MPlayer-DOCS