[MPlayer-DOCS] CVS: main/DOCS/man/en mplayer.1,1.1058,1.1059

[Diego Biurrun]

On Mon, Aug 22, 2005 at 03:10:10AM +0200, Diego Biurrun wrote:
> On Fri, Aug 12, 2005 at 08:32:02PM +0200, Roberto Togni wrote:
> > On Fri, 12 Aug 2005 19:04:42 +0200
> > Paul TT <paultt at hackerjournal.it> wrote:
> > 
> > > On Fri,  5 Aug 2005 21:57:48 +0200 (CEST)
> > > syncmail at mplayerhq.hu (Roberto Togni CVS) wrote:
> > > 
> > > > -.B \-sub-demuxer <number> (\-subfile only) (BETA CODE)
> > > > +.B \-sub-demuxer <name> (\-subfile only) (BETA CODE)
> > > >  Force subtitle demuxer type for \-subfile.
> > > > -Give the demuxer ID as defined in subreader.h.
> > > > +Give the demuxer name as printed by \-sub-demuxer help.
> > > > +For backward compatibility it also accepts the demuxer ID as
> > defined in
> > > > +libmpdemux/\:demuxer.h.
> > > 
> > > should it be as defined in subreader.h. ??????
> > 
> > Imo no because: subreader.h have no demuxer id in it (it has a list of
> > subtitle formats), demuxer functions require a demuxer_type_* variable
> > as input, the command parameter range checking in cfg-common.h was from
> > 1 to DEMUXER_TYPE_MAX
> > 
> > So i think that the previous explanation was wrong. If anybody disagree
> > please tell me so that i can fix it.
> 
> Umm, I think Paul is right here, there are subtitle format IDs defined
> in subreader.h that are different from the container demuxers.

Hmm, Roberto, given that -sub-demuxer help prints the same as -demuxer,
I think you need to have a look at and fix this.

Diego