[MPlayer-DOCS] [PATCH] How to do regression testing using CVS

Guillaume POIRIER poirierg at gmail.com
Sun Nov 27 19:50:27 CET 2005


Hi,

On 11/27/05, The Wanderer <inverseparadox at comcast.net> wrote:
> On 11/27/2005 05:32 AM, Guillaume POIRIER wrote:
>
> > Hi,
> >
> > Please find in attachment the last revision of the patch. I believe
> > I've addressed all comments.
> >
> > On 11/27/05, The Wanderer <inverseparadox at comcast.net> wrote:
> >
> >>> +If you have lot of hard disk free space (a full compile currently takes
> >>> +100 Mb), copy the oldest known working version before updating it; it will
> >>> +save time if you need to go back.
> >>
> >> As noted above, the number has not been changed. Also, you didn't
> >> address the question of whether we use "MB" or "Mb" (or even make
> >> any distinction between them).
> >
> > "MB" is used on the rest of the doc, so I switched to MB.
> >
> > Also, I did change the sentence to: "(a full compile currently takes
> > 100 MB, and around 300-350 MB if debugging symbols are enabled)".
> >
> > Is that any better? I believe it is.
>
> Yes, that's better.
>
> > +cvs update -PAd -D "2004-08-23"
> > +</screen>
> > +The date format is YYYY-MM-DD HH:MM:SS.
> > +Using this date format ensure that you will be able to extract patches
> > +in a way that will be compatible with the
> > +<ulink url="http://mplayerhq.hu/pipermail/mplayer-cvslog/">MPlayer-cvslog archive</ulink>.
>
> I think you missed part of the point of my previous comment. The reason
> for the "ensure that ... will be compatible" line is *because* there was
> the time-zone reference; if you omit the explicit time zone when
> attempting to get a specific date from Wine CVS, you will not
> necessarily get the exact snapshot you want. As I said, I've experienced
> that myself. (I'm not sure it makes a difference in practice what time
> zone is used, although it might, but using none can definitely cause
> problems.) If you're not going to include the time-zone identifier at
> all, you shouldn't really include the "compatible" sentence either.

All I want to say is "the date format is the same as in the cvslog
archives". I changed the sentence again to hopefully get to what
you're aiming at. Feel free to fix it if it still hurts your eyes :)

[..]

> And there's no need to re-post again unless you write a new section of
> text somewhere as a result of this; if all you do is make the latest
> round of changes, then feel free to commit the result as far as I'm
> concerned.

Okay, I'll commit my updated patch shortly. The reason why I try to
avoid committing broken stuff if that I don't want to give too much
work to the translators. That's all :)

Guillaume
--
Remember, if you ever need a helping hand, it's
at the end of your arm, as you get older, remember
you have another hand:
The first is to help yourself,
the second is to help others.
-- Audrey Hepburn




More information about the MPlayer-DOCS mailing list