[MPlayer-DOCS] CVS: main/help help_mp-en.h,1.198,1.199

Diego Biurrun diego at biurrun.de
Wed Nov 16 21:28:44 CET 2005


On Wed, Nov 16, 2005 at 08:24:45PM +0100, Alexander Strasser wrote:
> Diego Biurrun wrote:
> > On Tue, Nov 15, 2005 at 05:24:11PM +0100, Paul TT wrote:
> > > On Thu, 10 Nov 2005 03:39:34 +0100 (CET)
> > > syncmail at mplayerhq.hu (Alexander Strasser (beastd)) wrote:
> > > 
> > > > Log Message:
> > > > Test if source image dimensions are too big.
> > > > 
> > > > +// vo_xv.c
> > > > +#define MSGTR_VO_XV_ImagedimTooHigh "Source image dimensions are " \
> > > > +                                    "too high: %ux%u (maximum is
> > > %ux%u)\n"
> > > > +
> > > 
> > > why the \n??? all other messages are written as a standalone row...
> > > (except multiline msgs)
> > 
> > Yes, it's strange.  Feel free to directly fix these things in the
> > future.
> 
>   Now if anyone could tell me what the cryptic question meant...
>   And just for your information I never wrote `\n??'.
> 
>   And if you meant why I broke the line,

Yes, that's what we meant.

> it was just because I
> don't like overlong lines that don't fit into 80 columns. I
> thought there was affort to get rid of them. And it is done
> at least in two other messages two. But if you want to `fix'
> it then put the message on a line of its own.
> 
> #define MSGTR_VO_XV_ImagedimTooHigh \
> "Source image dimensions are too high: %ux%u (maximum is %ux%u)\n"

This looks much better and would probably also help with spotting overly
long lines.

I was unaware of lines that looked like yours.  I'm not against such a
format (though I would prefer the above), but it should be consistent.
The whole file should use the same formatting.

Diego




More information about the MPlayer-DOCS mailing list