[MPlayer-DOCS] CVS: main/help help_mp-en.h,1.192,1.193

[Diego Biurrun]

On Thu, Nov 03, 2005 at 01:10:41AM +0100, Paul TT wrote:
> On Tue,  1 Nov 2005 00:36:25 +0100 (CET)
> syncmail at mplayerhq.hu (Reynaldo H. Verdejo CVS) wrote:
> 
> > CVS change done by Reynaldo H. Verdejo CVS
> > 
> > Update of /cvsroot/mplayer/main/help
> > In directory mail:/var2/tmp/cvs-serv24386/help
> > 
> > +#define MSGTR_MPDEMUX_URL_MallocFailed "Memory allocation failed!\n" 
> ...
> > +#define MSGTR_MPDEMUX_MMST_MallocFailed "Memory allocation failed!\n"
> ...
> > +#define MSGTR_MPDEMUX_ASF_MallocFailed "Memory allocation failed\n"
> 
> could we use one message for all? this:
> #define MSGTR_MemAllocFailed "memory allocation failed"

Yes, definitely.

> and add a \n in the source files???? or define a msg like this, with
> that '\n'?

Why?

> .......................
> > +#define MSGTR_MPDEMUX_AIALSA1X_PcmBrokenConfig "Broken configuration
> for this PCM: no configurations available\n"
> > +#define MSGTR_MPDEMUX_AIALSA1X_UnavailableAccessType "Access type not
> available\n"
> > +#define MSGTR_MPDEMUX_AIALSA1X_UnavailableSampleFmt "Sample format
> ...
> > +#define MSGTR_MPDEMUX_AIALSA1X_AlsaXRUN "ALSA xrun!!! (at least
> %.3f ms long)\n"
> > +#define MSGTR_MPDEMUX_AIALSA1X_AlsaStatus "ALSA Status:\n"
> > +#define MSGTR_MPDEMUX_AIALSA1X_AlsaXRUNPrepareError "ALSA xrun:
> prepare error: %s"
> > +#define MSGTR_MPDEMUX_AIALSA1X_AlsaReadWriteError "ALSA read/write
> error"
> > +															   
> > +// ai_alsa.c
> > +
> > +#define MSGTR_MPDEMUX_AIALSA_PcmBrokenConfig "Broken configuration
> for this PCM: no configurations available\n"
> > +#define MSGTR_MPDEMUX_AIALSA_UnavailableAccessType "Access type not
> long)\n"
> ...
> > +#define MSGTR_MPDEMUX_AIALSA_AlsaStatus "ALSA Status:\n"
> > +#define MSGTR_MPDEMUX_AIALSA_AlsaXRUNPrepareError "ALSA xrun: prepare
> error: %s"
> > +#define MSGTR_MPDEMUX_AIALSA_AlsaReadWriteError "ALSA read/write
> error"
> ......................................
> 
> the messages for ALSA1X and ALSA are exactly the same. could not they be
> defined only once?

Yes, definitely.

> > +#define MSGTR_MPDEMUX_ASF_Bandwidth2SmallDeselectedVideo "bandwidth
> too small, " "deselected video stream\n"
> 
> why the two "..." "..."???

Beats me.

Feel free to whip up a patch that fixes these issues.

Diego