[MPlayer-DOCS] letter to distro mplayer packagers?

[Diego Biurrun]

On Thu, Dec 01, 2005 at 04:37:54PM +0100, Christian Marillat wrote:
> Diego Biurrun <diego at biurrun.de> writes:
> 
> > On Wed, Nov 30, 2005 at 03:27:34PM +0100, Christian Marillat wrote:
> >> Diego Biurrun <diego at biurrun.de> writes:
> >> > Why you include a skin uuencoded in the packaging patch and not create a
> >> > skin package that the mplayer-gui package depends on remains a mystery
> >> > to me.
> >> 
> >> Why not. May be a good idea :)
> >
> > Well, it makes it hard to swap out one skin for another and it makes the
> > packaging patch very bloated and hard to read...
> 
> diffstats is your friend

I'll look into it.

> > At the very least it's completely unconventional, I haven't seen this in
> > another Debian package.
> 
> If people are providing a mplayer package build with --enable-gui without a skin
> this package is broken.

They don't need to include the skin, though.  Making the mplayer-gui
package depend on a skin package is enough.

IMO an ideal solution would be to have several skin packages manage a
link in /etc/alternatives/mplayer-skin that would point to
/usr/share/mplayer/Skin/preferred_skin.

> > What about the various copies of the config files and the various
> > patches you apply?
> 
> You are talking about what exactly ?

You include several (modified) copies of the example configuration file,
located at etc/example.conf in the source tree, in your packaging patch.

You apply a number of patches to the vanilla MPlayer sources.  Do you
want me to list them?  I would be interested to know what they are for,
some of them could be interesting for upstream.

Diego