[MPlayer-DOCS] [PATCH] new section: muxing

Diego Biurrun diego at biurrun.de
Wed Apr 13 15:50:34 CEST 2005


On Wed, Apr 13, 2005 at 01:41:32PM +0000, Guillaume POIRIER wrote:
> 
> Here's the updated patch, that contains both The Wanderer's and 
> Dominik's suggestions.
> I hope I got them all.
> 
> +  as AVI, OGM, Matroska or NUT.

As suggested earlier, remove OGM from this list, you could replace it by
MPEG, which you mention on the next line.

> +  as mp3) audio, WAV and a few other audio formats too.

MP3

> +  MEncoder features experimental support of
> +  <systemitem class="library">libavformat</systemitem>

s/of/for/

> +  Please note that this support is highly experimental (but getting
> +  better every day), and will only work if you compiled
> +  <application>MPlayer</application> with the support of
> +  <systemitem class="library">libavformat</systemitem> enabled (which

with support for

> +  means that a pre-packaged binary version won't work in most cases).

will not

> +  Although it is the most widely-supported container format after MPEG-1,

A general question: Isn't the name of the container just MPEG?  Or does the
container have versions as well?

> +  use a less efficient codec such
> +  as MP3 or AC3.

Ubernit: Join those two lines for extra neatness, but this is unimportant.

> +  Having said all that, <application>MEncoder</application> does not
> +  currently even support variable-fps output or Vorbis encoding.

s/even//

> +  The Matroska project is a free, open standard container format,

Remove the word project, the Matroska project develops a container, but is
not a container of course.

> +  aiming to offer a lot of advanced features, which older containers
> +  like AVI can not handle, on an extensible basis.

cannot

I don't like "on an extensible basis" at the end of the sentence.  Maybe add
extensible to the list of attributes given to Matroska above.

> +  For example, Matroska supports Variable Bitrate audio content
> +  (VBR), Variable Framerates (VFR), chapters, file attachments,
> +  Error Detection (EDC) and modern A/V Codecs like "Advanced Audio

Do not capitalize all those words.  Either all letters that form and acronym
should be capitalized or none.  I'd go with none in this case.

> +  <ulink url="http://www.bunkus.org/videotools/mkvtoolnix/doc/mkvmerge-gui.html">
> +  guide to mkvmerge GUI (mmg)</ulink>

I prefer it if you put links on one line even if that line gets excessively
long.

> @@ -1878,3 +2016,4 @@
>  </sect1>
>  
>  </chapter>
> +

Useless cosmetics probably, remove this.

Looks very good otherwise, feel free to commit together with my suggestions.

Diego




More information about the MPlayer-DOCS mailing list