[MPlayer-DOCS] [PATCH] XviD documentation reaching almost completeness

[Guillaume POIRIER]

Le mar 07/09/2004 à 08:10, The Wanderer a écrit :
> Guillaume POIRIER wrote:
> The relevant portion is below, and:
> 
> > +.B overflow_control_strength=<0\-100>
> > +During two pass, a scaled bitrate curve is computed.
> > +The difference between that expected curve and the result obtained during
> > +encoding is called overflow.
> > +Obviously, the two pass Rate Controller tries to compensate that overflow
> > +distributing it over next frames to be encoded.
> > +This setting controls how much overflow is distributed at each new frame.
> > +Low values allow lazy overflow control, big rate bursts are compensated
> > +more slowly (could lead to lack of precision for small clips).
> 
> the problem is still there. As I said, and as I think Diego indicated
> and/or concurred, the inclusion or omission of the "for" drastically
> changes the meaning of the phrase; in this case, the meaning without
> does not remotely seem to be the one you want.

I read again the description and I think I finally understood where the
problem is. How about:
+This setting controls how much of the overflow is distributed at each
+new frame.

Please tell me if I'm wrong. I'm maybe that on written English, but the
simple fact that I write docs means I do care it's clear. ;-)

> For that matter, I don't see how the sentence in this version of the
> patch is at all different from the one in either of the previous two
> versions. Did you send the wrong one by mistake?

Unfortunately, that was the correct patch (that corrected the sentence
about "Higher values") :-(. I guess I didn't get were the problem was.


> I don't like to seem pushy, picky and/or bad-guy, but I'd rather get
> things right... and this is one of the few areas in which I know what
> "right" *is*.

Well I understand that, you know. As long as we can talk to each other
in a very civilized way, I'm open to all suggestions.
For me distributed dev like MPlayer is, works very well because people
are able to speak up as changes/improvements are made.
So don't worry, I didn't get the fuzz. ;-)

Regards,

Guillaume