[MPlayer-DOCS] [PATCH] XviD documentation reaching almost completeness

[The Wanderer]

Guillaume POIRIER wrote:

> Le lun 06/09/2004 à 22:03, The Wanderer a écrit :
> 
>> But - how is "compensate the overflow" good, or even valid,
>> English? I don't even know what it would mean; "to compensate X"
>> means roughly "to (pay back/reimburse) X for some hardship", which
>> makes absolutely no sense in this context. I don't know what the
>> code in question does, but I do not see any way to make the phrase
>> as given make any sense with much of *anything*. On the other hand,
>> "to compensate for X" means roughly "to add an offset so that X has
>> no net effect", and I can easily see how that could make sense in
>> this context.
> 
> Well, you're right. I changed that sentence that a Joe-user should
> now understand. Please have a look at the patch.

The relevant portion is below, and:

> +.B overflow_control_strength=<0\-100>
> +During two pass, a scaled bitrate curve is computed.
> +The difference between that expected curve and the result obtained during
> +encoding is called overflow.
> +Obviously, the two pass Rate Controller tries to compensate that overflow
> +distributing it over next frames to be encoded.
> +This setting controls how much overflow is distributed at each new frame.
> +Low values allow lazy overflow control, big rate bursts are compensated
> +more slowly (could lead to lack of precision for small clips).

the problem is still there. As I said, and as I think Diego indicated
and/or concurred, the inclusion or omission of the "for" drastically
changes the meaning of the phrase; in this case, the meaning without
does not remotely seem to be the one you want.

For that matter, I don't see how the sentence in this version of the
patch is at all different from the one in either of the previous two
versions. Did you send the wrong one by mistake?

I don't like to seem pushy, picky and/or bad-guy, but I'd rather get
things right... and this is one of the few areas in which I know what
"right" *is*.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.