[MPlayer-DOCS] [PATCH] XviD documentation reaching almost completeness

[Guillaume POIRIER]

Le lun 06/09/2004 à 16:14, The Wanderer a écrit :
> Diego Biurrun wrote:
> > has been replaced
> 
> No, "is replaced" is IMO correct in this context. Alternately you could
> change the tense of "is deprecated" as well, but I think the present
> tense works best in this case.
I agree, my new patch add consistency on that field.
> 
> >>+High values make RC compensate very hard the overflow, this can have a
> > 
> > High values make RC compensate the overflow very hard
> 
> Isn't that "compensate for"?
I don't think so, I prefer what Diego suggests.

> >>+We decided to allow users to set the amount of overhead per frame the
> >>+container generates (give only an average per frame).
> > 
> > (Give only an average per frame.)
> 
> No, the lowercase is correct in this context, because the parenthetical
> phrase is approximately a drop-in alternate for the preceding part of
> the sentence (following "to") and hence does not constitute a complete
> separate sentence. In order to actually be used as a replacement it
> would need more detail, which is currently presented in the
> non-parenthetical part actually used, but the principle remains.
I agree with you too

Other than that, when Diego says:
> > +.B quant_type=<h263|mpeg>
> > +Sets the type of quantizer to use.
> > +For high bitrates, you will find that MPEG quantization preserves >
> more detail.
> > +For low bitrates, the smoothing of H.263 will give you less block >
> noise.
> > +When using custom matrices, MPEG must be used.
> 
> I'm not sure if we shouldn't write mpeg and h263 here since the text
> refers to the parameters passed to XviD.  It's not completely clear
> in which way it is meant to be understood, though.

What I'm trying to say here is that the only current parameters allowed
here are: h263 or mpeg. For the rest, I guess it's just a matter of
taste.

Anyway, here's the new patch. I hope it applies correctly since I had to
manually edit it. When I try a dry-run, I tells me it lacks the header
for unified diff at line 3 of patch, but other than that it doesn't cry
out loud.

... and yes, I do think it's really cool to have a correct'n'up-to-date
documentation for XviD. It really deserves it, and it adds extra value
to mencoder.


Regards,
Guillaume

-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer1.0-20040906-en_man_xvid_1.0.x_options_round2.patch
Type: text/x-patch
Size: 9001 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-docs/attachments/20040906/6f5673d3/attachment.bin>