[MPlayer-DOCS] [PATCH] XviD: divx5bvop description update + closed_gop

[Dominik 'Rathann' Mierzejewski]

Hi,

On Friday, 05 November 2004 at 21:03, Guillaume POIRIER wrote:
> Hi,
> Le mercredi 03 novembre 2004 ? 23:08 +0100, Dominik 'Rathann'
> Mierzejewski a écrit :
> 
> > Do *NOT* use "deprecated" when you mean "unavailable/not working". There
> > were several other options marked as "deprecated" in xvid section and they
> > didn't work, too. Didn't I tell you to check in the dictionary?
> 
> Yes, you told me that indeed, but in such an unpleasant manner that I
> didn't consider your advice... :-(

I guess that's what I get for flaming. :-/

> But anyway, you're absolutely right, so here's an updated patch that
> fixes all the wrong usages of "deprecated".

Thank you.

> > Please fix this.
> 
> Done. Please review, comment, etc...

Here goes:

> diff -Nur -x CVS -x '.*' main/DOCS/man/en/mplayer.1 main_modif/DOCS/man/en/mplayer.1
> --- main/DOCS/man/en/mplayer.1	2004-11-02 18:22:23.000000000 +0100
> +++ main_modif/DOCS/man/en/mplayer.1	2004-11-05 21:00:12.000000000 +0100
> @@ -6495,8 +6495,8 @@
>  This might give better compression, but slows down encoding.
>  .br
>  .I WARNING:
> -This option is deprecated in XviD-1.0.x, as all is now taken care of
> -by the me_quality option.
> +As of XviD-1.0.x, this option isn't available alone as all is now taken
> +care of by the me_quality option.

I think a better wording would be:
"As of XviD-1.0.x, this option is not available separately, and its
functionality is included in the me_quality option."

>  When me_quality > 4, 4mv is activated.
>  .
>  .TP
> @@ -6525,7 +6525,7 @@
>  2pass mode: min & max quantizer for I/\:P-frames (default: 2\-31/\:2\-31)
>  .br
>  .I WARNING:
> -This option is deprecated in XviD-1.0.x, and is replaced by the
> +As of XviD-1.0.x, this option is replaced by the
>  [min|max]_[i|p|b]quant options.
>  .
>  .TP
> @@ -6544,8 +6544,7 @@
>  When using custom matrices, MPEG must be used.
>  .br
>  .I WARNING:
> -This option is deprecated in XviD-1.0.x, and is replaced by the quant_type
> -option.
> +As of XviD-1.0.x, this option is replaced by the quant_type option.
>  .
>  .TP
>  .B mod_quant
> @@ -6557,7 +6556,7 @@
>  by any MPEG4 decoder besides libavcodec or XviD.
>  .br
>  .I WARNING:
> -This option is deprecated in XviD-1.0.x.
> +As of XviD-1.0.x, this option is unavailable.
>  .
>  .TP
>  .B keyframe_boost=<0\-1000>
> @@ -6579,6 +6578,14 @@
>  (default: 30, 2pass mode only)
>  .
>  .TP
> +.B divx5bvop
> +Generate DivX5 compatible B-frames (default: on).
> +This seems to be only mandatory for old versions of DivX's decoder.

Syntactic nit: "This seems to be mandatory only for..."

> +.br
> +.I WARNING:
> +As of XviD-1.0.x, this option is replaced by the closed_gop option.
> +.
> +.TP
>  .B (no)greyscale
>  Make XviD discard chroma planes so the encoded video is greyscale only.
>  Note that this does not speed up encoding, it just prevents chroma data
> @@ -6597,7 +6604,7 @@
>  .
>  .TP
>  .B (no)packed
> -Create a bitstream which can be decoded delay-free.
> +Create a bitstream which can be decoded delay-free (default: off).
>  .br
>  .I WARNING:
>  This will generate an illegal bitstream, and will not be
> @@ -6608,10 +6615,6 @@
>  autodetection of some decoders might be confused.
>  .
>  .TP
> -.B divx5bvop
> -Generate DivX5 compatible B-frames (default: on).
> -.
> -.TP
>  .B max_bframes=<0\-4>
>  Maximum number of B-frames to put between I/\:P-frames (default: 0).
>  .
> @@ -6635,6 +6638,14 @@
>  (default: 0)
>  .
>  .TP
> +.B (no)closed_gop
> +This option controls if XviD must close a GOP (Group Of Pictures bounded
> +by two I-frames), which means that a GOP is independent from the next GOP.

Better:
This option tells XviD to close every GOP (Group Of Pictures bounded
by two I-frames), which makes GOPs independent from each other.

> +This implies just that the last frame of the GOP is eiter a P-frame or a

Syntactic nit:
This implies simply that... or This just implies that...

> +N-frame but not a B-frame.
> +This is usually a good idea to turn on the option (default\ : on).

Better:
"It is usually a good idea to turn on this option"

> +.
> +.TP
>  .B frame_drop_ratio=<0\-100> (max_bframes=0 only)
>  This setting allows the creation of variable framerate video streams.
>  The value of the setting specifies a threshold under which, if the

Regards,
R.

-- 
MPlayer RPMs maintainer: http://greysector.rangers.eu.org/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"