[MPlayer-DOCS] [PATCH] comments in patches.txt
eclipse7 at gmx.net
Sun Jun 27 14:14:45 CEST 2004
Extended the comment section of patches.txt a little.
The origin of these changes are the security problems
discovered recently. This rule should avoid most of
them in the future.
-------------- next part --------------
RCS file: /cvsroot/mplayer/main/DOCS/tech/patches.txt,v
retrieving revision 1.18
diff -u -r1.18 patches.txt
--- patches.txt 17 Jun 2004 08:43:18 -0000 1.18
+++ patches.txt 27 Jun 2004 11:56:00 -0000
@@ -31,7 +31,10 @@
any remaining cosmetics!
5. Comment parts that really need it (tricky side-effects etc).
- Commenting trivial code not required. Comments must be English!
+ Always document string operations! Comment on what you are doing
+ and why it is safe. This makes it easy to review and change your
+ code if needed. Commenting trivial code not required.
+ Comments must be English!
6. If you implement new features, add or change command line switches or
modify the behavior of existing features, please do not forget to also
More information about the MPlayer-DOCS