[MPlayer-DOCS] [PATCH] New and Improved DVD to MPEG4 guide (menc-feat-dvd-mpeg4)
diego at biurrun.de
Fri Jul 2 15:22:14 CEST 2004
Jason Tackaberry writes:
> Let me know if any changes are required before this patch can be merged.
This looks extremely good and I will merge it ASAP if you could make
some slight adjustments. You use (American style) two spaces after a
period while the rest of the docs use (European style) one space. I
use two spaces myself, but for consistency reasons I would prefer you
used one as in the rest of the docs. You also added some trailing
whitespace, but that's really minor, I can also remove it with one
A few (small) comments below:
> + When cropping, you'll want to increase the y-offset by
> + half the difference of the new height so that the resulting video is taken
> + from the center of the frame.
This is slightly confusing to me. What exactly is the difference of
the new height? A difference is always between two things. Is it new
vs old height?
> + The <option>softskip</option> filter is only included in very recent
> + versions of <application>MPlayer</application>. If your version doesn't
> + have <option>softskip</option>, you'll want to use the
> + <option>filmdint</option> filter instead.
This is not necessary IMO since this guide is younger than
> + yields higher quality than the defaults. You might try experimenting with
> + with this parameter (refer to the man page for the possible values) as
One with should be enough ;-)
> + source material. For example, if you find <systemitem
> + class="library">libavcodec</systemitem> produces too much blocky
> + artifacting, you could try *cmp=10. (This comparison function, NSSE, is
> + currently only available in CVS versions and is experimental.)
Again, this guide is younger than NSSE.
Maybe you could say that setting a *cmp option to 10 selects NSSE as
comparison function, it's not immediately obvious.
A thought that occurred to me now is that it might be interesting to
have a section that explains how to best maximize quality on a fixed
size encode, since it's quite common to target a CD or two as size.
More information about the MPlayer-DOCS