[MPlayer-DOCS] CVS: main/DOCS/xml Makefile, 1.16, 1.17 Makefile.inc, 1.13, 1.14

[Torinthiel]

On Sat, Jan 24, 2004 at 11:31:13PM +0100, Diego Biurrun CVS wrote:
> Update of /cvsroot/mplayer/main/DOCS/xml
> In directory mail:/tmp/cvs-serv27168
> 
> Modified Files:
> 	Makefile Makefile.inc 
> Log Message:
> Make the build system print everything it does.
> 
> 
> Index: Makefile.inc
> ===================================================================
> RCS file: /cvsroot/mplayer/main/DOCS/xml/Makefile.inc,v
> retrieving revision 1.13
> retrieving revision 1.14
> diff -u -r1.13 -r1.14
> --- Makefile.inc	20 Jan 2004 23:27:24 -0000	1.13
> +++ Makefile.inc	24 Jan 2004 22:31:11 -0000	1.14
> @@ -37,48 +37,48 @@
>  html-single: $(HTMLFILE)
>  
>  $(HTMLDIR)/index.html: main.xml $(CHUNK_XSL_DEPS)
> -	@if test "$(HTMLDIR)" = "" ; then \
> +	if test "$(HTMLDIR)" = "" ; then \
>  		echo "Error: HTMLDIR not set!!!"; \
>  		echo "Typically this means, that you've run make from a subdir of DOCS/xml."; \
>  		echo "Don't do this!"; \
>  		false; \
>  	fi

Wow, this one made me think I made a mistake running make. I don't see
it as a good idea to leave test for error visible. Especially to see
error message visible during test.

>  $(HTMLFILE): main.xml $(XSL_DEPS)
> -	@if test "$(HTMLFILE)" = "" ; then \
> +	if test "$(HTMLFILE)" = "" ; then \
>  		echo "Error: HTMLFILE not set!!!"; \
>  		echo "Typically this means, that you've run make from a subdir of DOCS/xml."; \
>  		echo "Don't do this!"; \
>  		false; \
>  	fi

Same here
Torinthiel

-- 
 Waclaw "Torinthiel" Schiller       GG#: 542916, 3073512
   torinthiel(at)wp(dot)pl
   gpg: B06901F1 fpr: FAA3 559F CAE9 34DE CDC8  7346 2B6E 39F2 B069 01F1
 "No classmates may be used during this examination"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-docs/attachments/20040125/0d9255ea/attachment.pgp>